Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the UUID allowlist option #1007

Merged

Conversation

chatziko
Copy link
Contributor

@chatziko chatziko commented Nov 23, 2023

@dshokouhi
Copy link
Member

Since this change will be in the beta first please add a beta flag so users know it's only available in the beta version one merged.

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a beta flag to indicate its a beta feature/change initially

@home-assistant home-assistant bot marked this pull request as draft November 23, 2023 17:24
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chatziko chatziko force-pushed the ble-transmitter-default-minor branch from 2ca3eb3 to 55f8a85 Compare November 23, 2023 18:02
@chatziko chatziko marked this pull request as ready for review November 23, 2023 18:04
@home-assistant home-assistant bot requested a review from dshokouhi November 23, 2023 18:04
@chatziko
Copy link
Contributor Author

Since this change will be in the beta first please add a beta flag so users know it's only available in the beta version one merged.

Done. I wasn't sure where to put it, to convey the fact that BETA referes only to

The iBeacon is capable of being detected by the iBeacon integration if its Minor field is set to the (default) value 40004

All the rest was valid before.

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged when parent is merged

@jpelgrom
Copy link
Member

@chatziko Is this PR still relevant? Looking at the core PR it seems that the approach is now to create a generic allowlist where the user could enter the app details, in which case this documentation change is incorrect and probably unnecessary.

@chatziko
Copy link
Contributor Author

@chatziko Is this PR still relevant? Looking at the core PR it seems that the approach is now to create a generic allowlist where the user could enter the app details, in which case this documentation change is incorrect and probably unnecessary.

Indeed using a hardcoded allowlisted minor value was the initial approach (old PR), it was later replaced with a manual UUID allowlist (new PR). So this documentation change is no longer relevant. It should maybe be replaced by a sentence inviting users to allowlist their UUID.

@dshokouhi
Copy link
Member

@chatziko would you be able to update this PR to reflect the upcoming changes?

@chatziko chatziko force-pushed the ble-transmitter-default-minor branch from 55f8a85 to 532f11e Compare January 25, 2024 08:23
@chatziko chatziko changed the title Document the whitelisted BLE Minor value 40004 Document the UUID allowlist option Jan 25, 2024
@chatziko
Copy link
Contributor Author

@chatziko would you be able to update this PR to reflect the upcoming changes?

Done. Note that I removed the beta flag, since from what I understand it refers to the companion beta, but now the change is purely on the HA side.

@dshokouhi dshokouhi merged commit b693899 into home-assistant:master Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants