-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the UUID allowlist option #1007
Document the UUID allowlist option #1007
Conversation
Since this change will be in the beta first please add a beta flag so users know it's only available in the beta version one merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a beta flag to indicate its a beta feature/change initially
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
2ca3eb3
to
55f8a85
Compare
Done. I wasn't sure where to put it, to convey the fact that BETA referes only to
All the rest was valid before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can be merged when parent is merged
@chatziko Is this PR still relevant? Looking at the core PR it seems that the approach is now to create a generic allowlist where the user could enter the app details, in which case this documentation change is incorrect and probably unnecessary. |
Indeed using a hardcoded allowlisted minor value was the initial approach (old PR), it was later replaced with a manual UUID allowlist (new PR). So this documentation change is no longer relevant. It should maybe be replaced by a sentence inviting users to allowlist their UUID. |
@chatziko would you be able to update this PR to reflect the upcoming changes? |
55f8a85
to
532f11e
Compare
Done. Note that I removed the beta flag, since from what I understand it refers to the companion beta, but now the change is purely on the HA side. |
See: