Set the default BLE transmitter minor value to 40004 #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is whitelisted by the ibeacon integration to ensure the beacon is processed even without a name.
dshokouhi
approved these changes
Nov 23, 2023
JBassett
approved these changes
Nov 25, 2023
20 tasks
|
The initial solution of a hard-coded allowlisted minor was replaced by a manual UUID allow list (new PR). So this PR should be probably reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently beacons sent by the BLE transmitter are ignored by the ibeacon integration, since they have an empty/default name. A workaround proposed here uses a whitelisted minor value (
40004) to force processing a beacon with no name.This tiny PR sets the default minor value to
40004. Most likely the user doesn't care about it, so it will transparently solve the issue for them.Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1007