Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Update heart rate sensor for Wear OS 4+ target #4552

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Breaking Change: Update heart rate sensor for Wear OS 4+ target #4552

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5c1080
Remove heart rate sensor for Wear OS 4+
jpelgrom Aug 3, 2024
078469c
Rework: request background permission separately
jpelgrom Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion wear/src/main/java/io/homeassistant/companion/android/sensors/HeartRateSensorManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import android.hardware.SensorManager.SENSOR_STATUS_ACCURACY_LOW
import android.hardware.SensorManager.SENSOR_STATUS_ACCURACY_MEDIUM
import android.hardware.SensorManager.SENSOR_STATUS_NO_CONTACT
import android.hardware.SensorManager.SENSOR_STATUS_UNRELIABLE
import android.os.Build
import android.util.Log
import androidx.core.content.getSystemService
import io.homeassistant.companion.android.common.R as commonR
Expand Down Expand Up @@ -57,8 +58,12 @@ class HeartRateSensorManager : SensorManager, SensorEventListener {
}

override fun hasSensor(context: Context): Boolean {
// Starting with Android 13 (T), background access requires BODY_SENSORS_BACKGROUND permission
// which must be allowlisted by OEMs. Because Home Assistant isn't allowlisted, the sensor only
// works while the app is visible and is practically useless, so don't make it available on 13+.
val packageManager: PackageManager = context.packageManager
return packageManager.hasSystemFeature(PackageManager.FEATURE_SENSOR_HEART_RATE)
return Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU &&
packageManager.hasSystemFeature(PackageManager.FEATURE_SENSOR_HEART_RATE)
}

private lateinit var latestContext: Context
Expand Down