Breaking Change: Update heart rate sensor for Wear OS 4+ target #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Aug 4, 2024
|
Given what we know in #4500 (comment) should we hold off on this? |
|
Oh I completely forgot about your comment, I still wanted to test this because I couldn't find it the first time. I'll do that in a couple of hours and comment. |
|
You're right, I must have missed something during previous tests (or an update happened). Handling this like background location with requesting the main permission first, then the background permission, seems to work. Updating the PR to change it. (Still a breaking change in a way: because a permission is added, users need to toggle the sensor on again.) |
jpelgrom
changed the title
- Requesting the background permission separately seems to work and allows the user to keep using this sensor after changing the target SDK version
dshokouhi
approved these changes
Sep 5, 2024
dshokouhi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the permission requirements for the heart rate sensor on Wear OS 4+ to handle the new behavior when targeting it. These permissions need to be requested in two stages like background location. Any user with the sensor currently enabled on Wear OS 4+, will need to re-enable it after updating.
Screenshots
n/a
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1087n/aAny other notes