Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApiResourceResponse mandatory and mark library as typed #464

Merged
merged 4 commits into from
Mar 19, 2022
Merged

Make ApiResourceResponse mandatory and mark library as typed #464

merged 4 commits into from
Mar 19, 2022

Conversation

ggravlingen
Copy link
Member

No description provided.

@ggravlingen ggravlingen changed the title Cleanup, mark library typed Make ApiResourceResponse mandatory and mark library as typed Mar 19, 2022
MartinHjelmare
MartinHjelmare reviewed Mar 19, 2022
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The py.typed file should go inside the pytradfri package. Also make sure it's included when building the package.

Example:
https://github.com/MartinHjelmare/aiovlc/blob/a1cfe347b397632d03637c76ffe2e8f786b2f68d/setup.py#L24-L25

@MartinHjelmare
Copy link
Contributor

Please move py.typed under pytradfri dir.

@MartinHjelmare MartinHjelmare merged commit f585f80 into master Mar 19, 2022
@MartinHjelmare MartinHjelmare deleted the Cleanup,-mark-typed branch March 19, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggravlingen @MartinHjelmare