Skip to content

Commit

Permalink
Make ApiResourceResponse mandatory and mark library as typed (#464)
Browse files Browse the repository at this point in the history
* Cleanup, mark library typed

* Add package data

* Fixes

* Move file
  • Loading branch information
ggravlingen authored Mar 19, 2022
1 parent 9fda7b2 commit f585f80
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 28 deletions.
Empty file added pytradfri/py.typed
Empty file.
37 changes: 9 additions & 28 deletions pytradfri/resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,41 +31,27 @@ class ApiResourceResponse(BaseResponse):
class ApiResource:
"""Base object for resources returned from the gateway."""

_model_class: type[ApiResourceResponse] | None = None
raw: TypeRaw | ApiResourceResponse
_model_class: type[ApiResourceResponse] = ApiResourceResponse
raw: ApiResourceResponse

def __init__(self, raw: TypeRaw) -> None:
"""Initialize base object."""
if self._model_class:
self.raw = self._model_class(**raw)
else:
self.raw = raw
self.raw = self._model_class(**raw)

@property
def id(self) -> int:
"""Id."""
if self._model_class:
resource_id = self.raw.id # type: ignore[union-attr]
else:
resource_id = self.raw[ATTR_ID] # type: ignore[index]
return resource_id
return self.raw.id

@property
def name(self) -> str | None:
"""Name."""
if self._model_class:
name = self.raw.name # type: ignore[union-attr]
else:
name = self.raw[ATTR_NAME] # type: ignore[index]
return name
return self.raw.name

@property
def created_at(self) -> datetime | None:
"""Return timestamp of creation."""
if self._model_class:
created_at = self.raw.created_at # type: ignore[union-attr]
else:
created_at = self.raw[ATTR_CREATED_AT] # type: ignore[index]
created_at = self.raw.created_at

if created_at is None:
return None
Expand All @@ -89,10 +75,8 @@ def observe_callback(value: TypeRaw) -> None:
Returns a Command.
"""
if self._model_class:
self.raw = self._model_class(**value)
else:
self.raw = value
self.raw = self._model_class(**value)

if callback:
callback(self)

Expand Down Expand Up @@ -125,9 +109,6 @@ def update(self) -> Command[None]:
"""

def process_result(result: TypeRaw) -> None:
if self._model_class:
self.raw = self._model_class(**result)
else:
self.raw = result
self.raw = self._model_class(**result)

return Command("get", self.path, process_result=process_result)
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
author_email="no@email.com",
long_description_content_type="text/markdown",
url=GITHUB_URL,
package_data={"pytradfri": ["py.typed"]},
include_package_data=True,
license="MIT",
keywords="ikea tradfri api iot light homeautomation",
Expand Down

0 comments on commit f585f80

Please sign in to comment.