Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OrderedDict regression #5925

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Fix OrderedDict regression #5925

merged 3 commits into from
Oct 11, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 5, 2023

PR #5890 which changed OrderedDict to dict. had a regression which was discovered in hvplot holoviz/hvplot#1164

@hoxbro
Copy link
Member Author

hoxbro commented Oct 6, 2023

This fix is not well received by our test suite.

Have to find the underlying issue.

@hoxbro hoxbro marked this pull request as draft October 6, 2023 06:18
@hoxbro
Copy link
Member Author

hoxbro commented Oct 6, 2023

An example with hvplot

import geoviews as gv
import xarray as xr
from holoviews.operation import contours

gv.extension("bokeh")

ds = xr.tutorial.open_dataset("air_temperature").isel(time=0)

p1 = gv.QuadMesh(ds, kdims=["lon", "lat"])
p2 = contours(p1, filled=True)
p2

@hoxbro hoxbro added this to the 1.18.0 milestone Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #5925 (afbf46e) into main (8ba691a) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5925      +/-   ##
==========================================
- Coverage   88.45%   88.32%   -0.14%     
==========================================
  Files         313      313              
  Lines       65209    65209              
==========================================
- Hits        57683    57595      -88     
- Misses       7526     7614      +88     
Flag Coverage Δ
ui-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/core/data/dictionary.py 90.90% <100.00%> (+0.31%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro marked this pull request as ready for review October 10, 2023 17:05
@hoxbro
Copy link
Member Author

hoxbro commented Oct 11, 2023

It's not an ideal fix, but it no longer errors in our CI or the example above.

@hoxbro hoxbro merged commit 8c9ce6d into main Oct 11, 2023
11 checks passed
@hoxbro hoxbro deleted the ordereddict_regression branch October 11, 2023 10:50
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants