Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all use of OrderedDict #5890

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Remove all use of OrderedDict #5890

merged 6 commits into from
Oct 3, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 16, 2023

OrderedDict is no longer required as dict has been in insertion order since Python 3.7.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Merging #5890 (d4713ef) into main (0b76098) will increase coverage by 0.00%.
The diff coverage is 90.32%.

@@           Coverage Diff           @@
##             main    #5890   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         311      311           
  Lines       64370    64345   -25     
=======================================
- Hits        56830    56809   -21     
+ Misses       7540     7536    -4     
Flag Coverage Δ
ui-tests 23.33% <27.74%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/core/overlay.py 68.45% <ø> (-0.22%) ⬇️
holoviews/element/comparison.py 90.42% <ø> (-0.03%) ⬇️
holoviews/plotting/bokeh/chart.py 88.18% <ø> (ø)
holoviews/tests/util/test_transform.py 95.73% <ø> (-0.02%) ⬇️
holoviews/element/tabular.py 50.00% <40.00%> (-0.80%) ⬇️
holoviews/element/stats.py 84.33% <50.00%> (ø)
holoviews/plotting/bokeh/callbacks.py 62.32% <50.00%> (ø)
holoviews/util/__init__.py 73.97% <50.00%> (ø)
holoviews/core/data/grid.py 86.27% <75.00%> (ø)
holoviews/plotting/mpl/plot.py 60.74% <80.00%> (ø)
... and 41 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 854e300 into main Oct 3, 2023
11 checks passed
@hoxbro hoxbro deleted the remove_ordereddict branch October 3, 2023 06:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants