-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-dimensional dim transforms on data sets #4080
Conversation
Sorry I never reviewed this. I'd very much like to get this into the release, so I'm going to take it over. |
Sorry for not replying earlier. I currently don't have a lot of spare time but I'm still interested in getting this in. |
@poplarShift I have a potentially much simpler implementation here, but one thing I haven't figured out is the drop_duplicate_data keyword argument? Why is that needed here? |
I did, but is there a good reason why I shouldn't have? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some really amazing and useful functionality. Among many other things, it makes the new link_selections even more powerful, by making it simple to express arbitrarily complex data transformation pipelines that can then be linked by dimension automatically. This is a major step up in power for HoloViews!
Co-Authored-By: James A. Bednar <jbednar@users.noreply.github.com>
@philippjfr Awesome! Sorry for being a bit slow with replying these days. I don't remember the exact reasons for the drop_duplicate_data kwarg, but I think they were specific to my implementation. Also thanks for seeing this through, I'm super excited about using this straight from the source instead of my monkey patched code snippets! As @jbednar said this is indeed a major step up for workflow design. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Addresses #3932 and #237
Supersedes #3636.
Related to #3790.
In this PR, we have the possibility to apply arbitrary dim transforms with multiple output values to Datasets, taking into account correct insertion of dimensions. The name of the new method used here is
.transform
, which provides two ways of specifying transforms. You either supply tuples of dimensions and dim_transforms as args or as kwargs and the method will apply these transforms and either replace the existing dimensions or add the newly added dimensions as new value dimensions.The upside of all of this is that we get complex statistical aggregation for free - see below for an example with hex bins that compute trends within each bin.
List of changes
Setup
Multi-dimensional dim transforms and aggregations
Example: Complex hex binning operations