fix dim insertion position

holoviz · Oct 31, 2019 · 2d36b9b · 2d36b9b
1 parent c096a7e
commit 2d36b9b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/holoviews/core/data/__init__.py b/holoviews/core/data/__init__.py
@@ -448,13 +448,13 @@ def add_dimension(self, dimension, dim_pos, dim_val, vdim=False, **kwargs):
         if vdim:
             dims = self.vdims[:]
             if dim_pos is None:
-                dim_pos = len(self.kdims)
+                dim_pos = len(self.vdims) + len(self.kdims)
             dims.insert(dim_pos, dimension)
             dimensions = dict(vdims=dims)
         else:
             dims = self.kdims[:]
             if dim_pos is None:
-                dim_pos = len(self.vdims)
+                dim_pos = len(self.kdims)
             dims.insert(dim_pos, dimension)
             dimensions = dict(kdims=dims)
 

diff --git a/holoviews/core/data/pandas.py b/holoviews/core/data/pandas.py
@@ -321,8 +321,6 @@ def sample(cls, dataset, samples=[]):
     @classmethod
     def add_dimension(cls, dataset, dimension, dim_pos, values, vdim):
         data = dataset.data.copy()
-        if vdim:
-            dim_pos += len(dataset.kdims)
         if dimension.name not in data:
             data.insert(dim_pos, dimension.name, values)
         return data