This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Adding dynamic titles and some accessibility fixes + loading spinner and secondary nav fix rui 1282 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fazanki
force-pushed
the
bug/RUI-1282
branch
2 times, most recently
from
December 11, 2018 12:22
2cd49c1
to
6138dec
Compare
fazanki
force-pushed
the
bug/RUI-1282
branch
from
December 11, 2018 15:19
4648505
to
b435e13
Compare
frontr-uk
reviewed
Dec 11, 2018
I would have split up this PR into 3 Pr's, but I added the Pr description:
|
Semantic Commit Messages and Pr titlesmake it easier to read. They got great examples:
|
yeah that was a good idea adding the good PR comments |
fazanki
force-pushed
the
bug/RUI-1282
branch
from
December 11, 2018 16:31
90d173c
to
7da4ccb
Compare
fazanki
force-pushed
the
bug/RUI-1282
branch
from
December 11, 2018 16:53
7da4ccb
to
b105331
Compare
fazanki
force-pushed
the
bug/RUI-1282
branch
from
December 12, 2018 16:33
b105331
to
4a254ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
Feat: Page titles: Introducing dynamic titles
Fix: Web accessibility & Secondary nav fix rui 1282
Feat: introducing spinner
Before creating a pull request make sure that:
Does this PR introduce a breaking change? (check one with "x")