Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Adding dynamic titles and some accessibility fixes + loading spinner and secondary nav fix rui 1282 #401

Merged
merged 8 commits into from
Dec 12, 2018

Conversation

fazanki
Copy link
Contributor

@fazanki fazanki commented Dec 11, 2018

This PR includes the following:
Feat: Page titles: Introducing dynamic titles
Fix: Web accessibility & Secondary nav fix rui 1282
Feat: introducing spinner

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@fazanki fazanki force-pushed the bug/RUI-1282 branch 2 times, most recently from 2cd49c1 to 6138dec Compare December 11, 2018 12:22
@fazanki fazanki requested a review from frontr-uk December 11, 2018 12:24
src/app/app.component.ts Outdated Show resolved Hide resolved
src/app/app.component.ts Outdated Show resolved Hide resolved
src/app/domain/components/header/header.component.html Outdated Show resolved Hide resolved
src/app/routing/pages/view-case/view-case.component.ts Outdated Show resolved Hide resolved
src/app/app.component.ts Show resolved Hide resolved
src/app/app.module.ts Show resolved Hide resolved
src/app/routing/pages/view-case/view-case.component.ts Outdated Show resolved Hide resolved
src/app/domain/components/header/header.component.html Outdated Show resolved Hide resolved
@frontr-uk
Copy link
Contributor

I would have split up this PR into 3 Pr's, but I added the Pr description:

This PR includes the following:
Feat: Page titles: Introducing dynamic titles
Fix: Web accessibility & Secondary nav fix rui 1282
Feat: introducing spinner

@frontr-uk
Copy link
Contributor

Semantic Commit Messages and Pr titlesmake it easier to read.
Here is a link: https://seesparkbox.com/foundry/semantic_commit_messages

They got great examples:

chore: add Oyster build script
docs: explain hat wobble
feat: add beta sequence
fix: remove broken confirmation message
refactor: share logic between 4d3d3d3 and flarhgunnstow
style: convert tabs to spaces
test: ensure Tayne retains clothing

@fazanki
Copy link
Contributor Author

fazanki commented Dec 11, 2018

yeah that was a good idea adding the good PR comments

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 11, 2018 16:26 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 11, 2018 16:44 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 11, 2018 17:07 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 09:31 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 09:55 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 10:29 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 11:00 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 11:25 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 12:21 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview December 12, 2018 14:25 Abandoned
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants