-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(18150): Manual grouping of nodes in the workspace to create new contexts for metrics #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to change a group name. When I create a group, it is always called "Untitled Group". This is very helpful.
I seem to be able to create arbitrary connections between group box and nodes which doesn't seem correct - by clicking and holding between the connector point at the bottom of a grouping box and dragging to the HiveMQ edge entity.
It wasn't entirely clear how to go about creating groupings in the first place. I have to experiment with various key presses to make a group appear. It we are adding this as function, it should be clear how to create these things to add value.
A feature to edit the metadata of a group will be covered in another PR. See https://hivemq.kanbanize.com/ctrl_board/57/cards/18214/details/
Ah, that's a bug with the canvas editor. Will fix.
This is an issue to address very quickly. Either with documentation that starts covering the UI, or (and?) some tour-like functionality to introduce users to the UX: Will be covered in another PR, see https://hivemq.kanbanize.com/ctrl_board/57/cards/18236/details/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like all the points will be covered in upcoming work units
b250c10
to
307e083
Compare
- add open/close control - update styling and layout
- add initial state - add a reset action
- remove unused action
- redesign the toolbar - add a confirmation before ungrouping - fix accessibility
fix(18218): Fix the availability of the "remove metrics" button for Stats * fix(18218): add props for the state of the editor and condition avail… * test(18218): fix tests
fix(18246): fix focus/selected status of nodes in workspace * style(18246): add a fix to ReactFlow default style to match ChakraUI … * style(18246): update style of wrapper node * chore(18216): fix bug with CSS Linting script * chore(18216): fix prettier
fix(18204): Refactor the location of a group and its nodes * fix(18214): update type for group actions * fix(18214): add bounding rect routine for groups * fix(18214): update computation of position at creation and ungrouping * fix(18214): fix connectable status * fix(18214): fix group rendering * test(18214): fix tests
feat(18214): Add editor for the group metadata * feat(18214): add color picker component * refactor(18214): refactor group metadata * feat(18214): add store action for updating group metadata * feat(18214): add metadata editor * test(18214): add tests * fix(18214): update translations * fix(18214): fix rebase
fix(18293): Change mouse and keyboard interactions with nodes * fix(18293): add context menu hooks for the nodes * fix(18293): add navigation to panel on both double click and context … * fix(18293): change navigation to panel on click * refactor(18293): refactor the toolbar for the groups * test(18293): fix test * fix(18293): fix translations * test(18293): add tests * fix(18293): add keyboard access to the node's panel
…#235) * refactor(18216): update the way groups are updating the status * test(18216): update tests
…re (#243) * feat(18161): add a store for the metrics * refactor(18161): replace the deprecated localStorage with the new met… * test(18161): add tests * chore(18077): little bit of cleaning
…244) * fix(18077): fix the group panels so that overview and observability b… * refactor(18077): add char themes to the types * refactor(18077): create a colorscheme for each grouped entity and ass… * refactor(18077): add the chart theme to the props * refactor(18077): apply the theme to the Stat chart * refactor(18077): apply the theme to the line chart * refactor(18077): apply the theme to the bar chart * fix(18077): fix legend * fix(18077): fix x-axis ticks snd labels * refactor(18077): add a custom tooltip to all charts * style(18077): fix style of stat chart * fix(18077): fix translations * refactor(18077): refactor the tooltip * test(18077): add tests * test(18077): fix tests * fix(18077): hide the value from the bars * test(18077): fix test * fix(18077): add entity name into the series name
307e083
to
72e68e8
Compare
See https://hivemq.kanbanize.com/ctrl_board/57/cards/18150/details/
This PR is the last step in the "metrics" initiative. It allows users to manually select adapters in the workspace and group them in an identifiable "entity" connected to the
Edge
.Each group is a node exactly like the adapters or the bridges and reacts similarly: clicking on it will open a property panel, this time containing info related to all the adapters included.
Adapters within a group can still be accessed and manipulated. In particular, each adapter still has its link to the
Edge
However, the group can be "collapsed", resulting in individual adapters' links being "combined" in a single, summarised, link.
Clicking on the link's observability icon opens a side panel, similar to the other links. This time, however, metrics from all the grouped adapters are available for selection and visualisation in one of the charts.
Grouping adapters will allow users
Edge
in a more meaningful way (for example by grouping adapters that are located on the same site)Features
localStorage
. The layout of the graph and the groups (topology) will be all maintained across sessionsWorkspace
canvas contains a "group" command (in the top-left corner) that appears once at least two adapters are selected (use the shift+drag paradigm). While many nodes might be selected, the new group will only include adapters that are not already in a groupOut-of-scope
, see https://hivemq.kanbanize.com/ctrl_board/57/cards/18215/details/
Before
After