fix(18204): Refactor the location of a group and its nodes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
changed the base branch from
master
to
feat/18150/workspace-manual-grouping
vanch3d
force-pushed
the
fix/18204/group-position
branch
from
9cae4f4 to
41d3174
Compare
vanch3d
merged commit 6e9fb52
into
feat/18150/workspace-manual-grouping
9 checks passed
vanch3d
added a commit
that referenced
this pull request
Dec 19, 2023
fix(18204): Refactor the location of a group and its nodes * fix(18214): update type for group actions * fix(18214): add bounding rect routine for groups * fix(18214): update computation of position at creation and ungrouping * fix(18214): fix connectable status * fix(18214): fix group rendering * test(18214): fix tests
vanch3d
added a commit
that referenced
this pull request
Dec 20, 2023
fix(18204): Refactor the location of a group and its nodes * fix(18214): update type for group actions * fix(18214): add bounding rect routine for groups * fix(18214): update computation of position at creation and ungrouping * fix(18214): fix connectable status * fix(18214): fix group rendering * test(18214): fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/18204/details/
This PR improves the computation of the initial location of a group and, at its deletion, of its nodes.
The changes guarantee that, when a group is created, the selected nodes remain at the same visual position on the canvas. Similarly, when the nodes are ungrouped, their visual positions remain the same on the canvas. when the group is deleted.
The new implementation ensures that repetitive grouping and ungrouping don't introduce any "drift" on the visual canvas.
The PR also fixes two visual aspects of nodes on the graph:
Before
After