feat(18003): add localStorage for the configs of the metric panels #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
changed the base branch from
master
to
refactor/17951/metric-editor-ux
simon622
approved these changes
Dec 5, 2023
vanch3d
added a commit
that referenced
this pull request
Dec 5, 2023
reactor(17951): Refactor the metrics editor to a better collapsible UX * refactor(17951): clean metric flags * fix(17951): change portal for the select component in order to be int… * refactor(17951): refactor the collapsible component of the editor * refactor(17951): fix translations * fix(17951): fix import & testid * test(17951): add test * Merge pull request #223
vanch3d
added a commit
that referenced
this pull request
Dec 5, 2023
reactor(17951): Refactor the metrics editor to a better collapsible UX * refactor(17951): clean metric flags * fix(17951): change portal for the select component in order to be int… * refactor(17951): refactor the collapsible component of the editor * refactor(17951): fix translations * fix(17951): fix import & testid * test(17951): add test * Merge pull request #223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/18003/details/
This PR is a follow-up to the main metrics initiative, see #215. It adds persistence to the obervability panels created by the users, ensuring consistency across session.
The persistency is done through
localStorage, under individual keys (i.e.edge.reports-#####).Out-of-scope