-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(15311): Add metrics charting to the links in the worspace #215
Conversation
6b4ca2e
to
c6ec4e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Question - I struggled to initially figure out that graphs were only available by clicking on the icon on the connectors versus the node of the object itself. I was wondering why we have decided to break up the functionality, when it seems like the component could be reusable on the main flyout (since we already have counters, just not the graphs)?
The question RE: the different visual approach has been answered, and we have exciting new features coming that require this. |
- refactor metrics props
reactor(17951): Refactor the metrics editor to a better collapsible UX * refactor(17951): clean metric flags * fix(17951): change portal for the select component in order to be int… * refactor(17951): refactor the collapsible component of the editor * refactor(17951): fix translations * fix(17951): fix import & testid * test(17951): add test * Merge pull request #223
c2fe1ba
to
2ff7cfc
Compare
See https://hivemq.kanbanize.com/ctrl_board/57/cards/15311/details/
This PR is the first step of an initiative to add basic observability to the Edge web application. It extends the existing
Metrics
visualisation by adding two sets of features:Workspace
to provide context for the selection and visualisation of the metricsCharts are reusing the existing pattern designed for the basic metric Stat, i.e. the selection of one of the available metrics for visualisation. This time, the users are allowed to choose one of the available chart types for visualisation. For this PR, we are adding support for
Line Chart
andBar Chart
visualisation.While metrics Stat was available in the side panel opened by clicking on one of the "nodes" (adapter or bridge), this PR exploits the connector between the nodes and the edge by reifying that connection and providing a full "observability" panel designated to the flow of data going through it. It allows us to provide a strong context to the available metrics (only those related to the nodes connected by the connectors) but also interesting extensibility with dynamic grouping of nodes.
The expected UX is as follows:
Out-of-scope
localStorage
. This will be done in a subsequent ticket. See https://hivemq.kanbanize.com/ctrl_board/57/cards/18003/details/Before
After