Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tx list timestamp filter options #2015

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zone117x
Copy link
Member

Closes #1996

Add timestamp (by burn_block_time) filter options to /extended/v1/tx

Example usage: /tx?start_time=1704067200&end_time=1706745599 (one or both can be specified)

Copy link

Vercel deployment URL: https://stacks-blockchain-3vvqasv0f-blockstack.vercel.app 🚀

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.79%. Comparing base (542973c) to head (14fe1f4).

Files Patch % Lines
src/api/routes/tx.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2015      +/-   ##
===========================================
+ Coverage    72.76%   72.79%   +0.03%     
===========================================
  Files           94       94              
  Lines        12637    12647      +10     
  Branches      2911     2976      +65     
===========================================
+ Hits          9195     9207      +12     
+ Misses        3420     3279     -141     
- Partials        22      161     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we have an index on burn_block_time? If not, we should add one before merging

@zone117x
Copy link
Member Author

@rafaelcr yep we have a burn_block_time index 👍

@zone117x zone117x merged commit e7c224b into develop Jun 25, 2024
31 checks passed
@zone117x zone117x deleted the feat/tx-list-timestamp-filter branch June 25, 2024 07:53
blockstack-devops pushed a commit that referenced this pull request Jul 8, 2024
## [7.12.0](v7.11.1...v7.12.0) (2024-07-08)

### Features

* tx list contract id/name filter options ([#2018](#2018)) ([9c2fd78](9c2fd78))
* tx list nonce filter option ([#2023](#2023)) ([88fc5ce](88fc5ce))
* tx list timestamp filter options ([#2015](#2015)) ([e7c224b](e7c224b))
* tx ordering options ([#2005](#2005)) ([ae78773](ae78773))
* tx to/from address options ([#2012](#2012)) ([542973c](542973c))
* update api toolkit ([71da884](71da884))

### Bug Fixes

* pox events should use same index as associated contract log event ([#1994](#1994)) ([b1d6be9](b1d6be9)), closes [#1983](#1983)
@blockstack-devops
Copy link

🎉 This PR is included in version 7.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamp filter options to /extended/v1/tx
3 participants