Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tx to/from address options #2012

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

He1DAr
Copy link
Collaborator

@He1DAr He1DAr commented Jun 18, 2024

Closes #1997

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.79%. Comparing base (ae78773) to head (d8a2677).

Files Patch % Lines
src/api/routes/tx.ts 75.00% 2 Missing ⚠️
src/datastore/pg-store.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2012      +/-   ##
===========================================
+ Coverage    72.75%   72.79%   +0.03%     
===========================================
  Files           94       94              
  Lines        12624    12637      +13     
  Branches      2957     2965       +8     
===========================================
+ Hits          9185     9199      +14     
+ Misses        3417     3277     -140     
- Partials        22      161     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 18, 2024

Vercel deployment URL: https://stacks-blockchain-2hnljrhx9-blockstack.vercel.app 🚀

@He1DAr He1DAr requested review from zone117x and rafaelcr June 18, 2024 16:21
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from c56ebc3 to 117e3db Compare June 18, 2024 16:41
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from 117e3db to d2a7994 Compare June 18, 2024 16:45
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from d2a7994 to 1b55580 Compare June 18, 2024 16:55
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from 1b55580 to ac6e170 Compare June 18, 2024 17:59
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from ac6e170 to 29133c0 Compare June 18, 2024 18:10
src/api/routes/tx.ts Outdated Show resolved Hide resolved
@He1DAr He1DAr force-pushed the feat/tx-to-from-address-opts branch from 29133c0 to d8a2677 Compare June 19, 2024 14:10
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @He1DAr!

@zone117x zone117x merged commit 542973c into develop Jun 20, 2024
30 checks passed
@zone117x zone117x deleted the feat/tx-to-from-address-opts branch June 20, 2024 10:08
blockstack-devops pushed a commit that referenced this pull request Jul 8, 2024
## [7.12.0](v7.11.1...v7.12.0) (2024-07-08)

### Features

* tx list contract id/name filter options ([#2018](#2018)) ([9c2fd78](9c2fd78))
* tx list nonce filter option ([#2023](#2023)) ([88fc5ce](88fc5ce))
* tx list timestamp filter options ([#2015](#2015)) ([e7c224b](e7c224b))
* tx ordering options ([#2005](#2005)) ([ae78773](ae78773))
* tx to/from address options ([#2012](#2012)) ([542973c](542973c))
* update api toolkit ([71da884](71da884))

### Bug Fixes

* pox events should use same index as associated contract log event ([#1994](#1994)) ([b1d6be9](b1d6be9)), closes [#1983](#1983)
@blockstack-devops
Copy link

🎉 This PR is included in version 7.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to/from address filter options to /extended/v1/tx
3 participants