Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure RNBGL startOnBoot,stopOnTerminate more robustly 2508 #3025

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

bengtan
Copy link
Contributor

@bengtan bengtan commented Oct 29, 2018

This PR is an interim fix. For the longer term solution, see: [dev] RNBGL configuration with ready() is problematic #3024.

@bengtan
Copy link
Contributor Author

bengtan commented Oct 29, 2018

This PR is an interim fix. For the longer term solution, see: [dev] RNBGL configuration with ready() is problematic #3024.

@bengtan
Copy link
Contributor Author

bengtan commented Oct 29, 2018

'codepush verified' via #2508 (comment)

@aksonov
Copy link
Contributor

aksonov commented Oct 30, 2018

LGTM

@aksonov aksonov merged commit 0c1ba5a into master Oct 30, 2018
@bengtan bengtan deleted the 2508-rnbgl-config-interim-workaround branch November 13, 2018 07:49
@bengtan bengtan mentioned this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants