Version 3.9.3.1

[bengtan]

Objective: Publish an incremental bugfix release (nominally 3.9.3.1) to the App Store.

As of writing, the most recent App Store release is 3.9.3.

We want to release one, or a few, important bugfixes. We don't want to go through a full QA cycle of 3.9.4 or newer so it's just '3.9.3+specific fixes'.

I'm tending towards using codepush for this so we don't have to go through the whole App Store submission process but I'm open to counter-arguments.

Here's my suggested to-do list of changes and fixes (on top of 3.9.3):

• Show firebase errors on Verify Phone screen (Show firebase errors on Verify Phone screen #2988)
• Display more version info for codepushes (Display more version info for codepushes #3009)
• App not updating users location with app closed (App not updating users location with app closed #2508)
• Fix mixpanel calls with object payloads (Fix mixpanel calls with object payloads #3142)

For #2508 ... I won't be applying the full fix (PR 3107) that is currently on master (because that is based on 3.10.x and it doesn't patch cleanly). Instead, I'll create a minimal quick-and-dirty-ish fix.

For #3142 ... That's still a work-in-progress, but if there is a fix in the near future, I'm happy to wait for it so it goes into 3.9.3.1.

---

Questions:

Does anyone have any concerns about doing this as a codepush-only version? Anyone want to argue that it should also be a TestFlight release and an App Store submission?

Does anyone have suggested changes for the to-do list?

[aksonov]

I agree. Push it to Testflight staging app first so Miranda could verify.

[bengtan]

Version 3.9.3.1

Version 3.9.3.1 is available.

It's been tagged iphone-3.9.3.1 on the branch 3.9.3.x.

Here is the changelog since the most recent App Store release (3.9.3):

# 3.9.3.1 - 2018 Dec 10

* Show firebase errors on Verify Phone screen (#2988)
* Backport as many LocationStore.ts changes as possible.
  * Configure RNBGL startOnBoot,stopOnTerminate more robustly (PR #3025)
* Rework Location Store and RNBGL (#3071, PR #3107)
* Display more version info for codepushes (#3009, PR #3072, PR #3098)
* Submit bugsnag for any mixpanel tracking failures (PR #3145)

The main change is to fix #2508 (via two PRs #3025 and #3107), although there are some cosmetic and minor changes as well.

Staging

I've codepushed it to StagingBeng (targeting Staging 3.9.2 and 3.9.3)

If you go to your own user profile, the version string should say 'Version 3.9.3.1 (3.9.3-StagingBeng-v33)'.

To install it, please install Staging 3.9.2 or 3.9.3 and go to the codepush debug screen.

Downgrading from 3.10.x

If you are currently running Staging 3.10.x, it is advisable to uninstall and then install Staging 3.9.2 or 3.9.3.

Downgrading from 3.10.x is not supported. When I tried it, the app just hanged.

[bengtan]

Production

I've also codepushed 3.9.3.1 to Prod 'internal' by targeting TestFlight 3.9.2.

This is a mandatory codepush.

To install, install version 3.9.2 from TestFlight, open it and wait for a few minutes for the codepush subsystem to download 3.9.3.1. You should see the screen go white for a few seconds when 3.9.3.1 has been downloaded and is restarting.

To confirm that you have it, go to your user profile. The version string should say 'Version 3.9.3.1 (3.9.2-v17)'

[bengtan]

This is done. It's not really QA-able so I'm closing.

If any bugs arise, please post new tickets.