WIP - addresses #1441 #1496
Merged
WIP - addresses #1441 #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code looks fine, just need some QA feedback. |
|
@southerneer The problem is the code doesn't select a correct bot after pressing (i.e. we need to improve algorithm to make it work - check QA's feedback). If you have good idea how to improve it - feel free to commit. I was not able to find other solution yet... |
|
I wasn't able to repro the problem with not selecting the correct bot. Everything worked fine on my end. |
|
Merging this for a staging release...we can revisit if it needs more tweaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using workaround mentioned react-native-maps/react-native-maps#1731 (comment)
It is weird hack and it basically works, but accuracy of selecting of correct marking could be worse, need QA check and probably more adjustments.