Explore Nearby: Users not able to zoom in on clusters of bot pins

[mstidham]

Title: Users not able to zoom in on clusters of bot pins

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus
iOS:	10.3.3
tr Version:	1.56.0 (120)
Environment	Staging
Codepush:	Staging-Pavel
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:
Bypass handle?:	@TestyTester
Location access type?	Always
Does this issue occur on other environments?	No
Time issue occurred (UTC)	9:55 PM

Observed Result:

When user has multiple bot pins in a confined location the user can't zoom in.

Expected Result:

User should be able to zoom into the map regardless of how many bot pins are in that location

Steps to reproduce:

1. On Explore Nearby navigate to a cluster of multiple bot pins
2. Zoom in

Related Screenshots/Video Links:

---

[zavreb]

@aksonov feel free to reproduce this one using testytester bypass account, with current location being mooreland, ok... (where @mstidham lives) unless you have your own account with multiple bot pins within one area

[mstidham]

@aksonov this is still an issue for me. If my finger is touching a bot pin I can't zoom into that area. Also some bot pins shake while zooming or trying to zoom.

https://app.box.com/s/q7wr4kmb2qcq7m8v1t45j9y3lbw4nyzh

[aksonov]

It is how react-native-maps works now. I'm not sure how I can fix it. I found similar issue:
react-native-maps/react-native-maps#1731

[aksonov]

However I decreased image marker size, so now it would be much easier to tap an area outside the markers.

[zavreb]

Per discussed limitations, this still works much better now, except bot previews only show bot titles now (instead of the full address, may not be an issue bc Explore Nearby will undergo redesign nonetheless)... cc: @thescurry

Per @thescurry's feedback, please enable the address for ALL bot previews on Explore Nearby, the address only shows for a few bot pins cc: @aksonov

[aksonov]

1. Using workaround mentioned Markers hijacking map zoom even when child views have pointer events none set on them react-native-maps/react-native-maps#1731 (comment)

It is weird hack and it basically works, but accuracy of selecting of correct marking could be worse, need QA check and probably more adjustments.

2. About problem with the address - I hope that bug was fixed already - the address was not filled at all (so we can't fix it for such bots), please check new bots only - I see the address for them...

[thescurry]

@aksonov Maybe our upgrade to the latest RN will help resolve some of this too? I was reading the release notes for "react-native-maps" and it would appear they specifically only support "the latest RN version"... which is constantly changing. 🤔

[southerneer]

@mstidham @zavreb any feedback on this from @aksonov 's codepush this morning?

[zavreb]

Believe a spinoff ticket from this was #1498 (which I cannot reproduce).

A few things:

I think the way we are able to tap into bots is okay enough. Though we will have to work on it further for densely populated areas (urban)

On staging this is practically what the QA team deals with since we're often creating bots at our current location in order to test the app, this does not reflect the real life case on how users will experience the app, it is a bit difficult to navigate this, but it works good today:

This is the more realistic case on what users will deal with for the foreseen future...tapping on bots works well with this case:

A few things regarding addresses:

I am still not seeing addresses populate for all bots in the preview with the codepush-pavel fix:

But when I retap I finally see it:

And here for the Bot Profile, it works.

I do have some instances where I am unable to tap on bots like this:

Per current limitations I am happy to move this ticket forward, except for Bot Preview addresses not showing (unless @thescurry is willing to overlook that for this ticket and work on it later)

Pending @mstidham, @irfirl and @thescurry's feedback

[irfirl]

LGTM other than the bot preview addresses.

[mstidham]

I'm seeing an issue of not being able to select any bot pin. The user gets the same bot profile banner regardless of what bot pin they tap on.
See video attached: https://app.box.com/s/69pnbmz6nnwsaoo7hd2vkymjannmdw0s

[zavreb]

@mstidham as I wrote in the above ticket, we should not QA when our Explore Nearby looks like our Staging Environment. We should QA for areas in Explore Nearby that resemble our Production environment.

Will reiterate this point for this ticket:

Per current limitations I am happy to move this ticket forward, except for Bot Preview addresses not showing (unless @thescurry is willing to overlook that for this ticket and work on it later)

QA should focus on areas like this:

[aksonov]

Becky, if the address is not shown for new bots, it means it was not filled/created during creation/change and it is the bug that should be fixed. Please create ticket if this problem exists. Are you sure that my improvement is accurate? I asked Eric to look at it to improve if possible.

…

On 8 Nov 2017, at 21:20, Rebecka Z ***@***.***> wrote: @mstidham <https://github.com/mstidham> as I wrote in the above ticket, we should not QA when our Explore Nearby looks like our Staging Environment. We should QA for areas in Explore Nearby that resemble our Production environment. Will reiterate this point for this ticket: Per current limitations I am happy to move this ticket forward, except for Bot Preview addresses not showing (unless @thescurry <https://github.com/thescurry> is willing to overlook that for this ticket and work on it later) QA should focus on areas like this: <https://user-images.githubusercontent.com/10053657/32572382-35efb430-c47f-11e7-8f31-b17a1ddb6ac9.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQpcdlq-y8RsZ3BRZvRaixCc-2FH7k_ks5s0g0TgaJpZM4QDkxx>.

[southerneer]

Everything seems to work perfectly on my end. The clustering problem won't be a big deal in prod for a while so I think we should defer that. Probably we could come up with something on the design side to group pins that are close together instead of rendering each one.

https://losangeles.craigslist.org/d/apts-housing-for-rent/search/apa

Click "see in map view"

[zavreb]

@thescurry mentioned something that maps has an upgrade that allows for UI clustering, whereas we have a pin that says 5+ to represent 5 bots when tapped into it. Will focus on that when we have too many bots...A VERY FINE PROBLEM TO HAVE 😉 ...next year

@aksonov, my brain died today, I don't think I understand, can you look at this video please...don't think we're on the same page, we can talk further during standup...

https://app.box.com/s/2r4kzhtc8adohdaoctw00qdsmgwlnn3j

cc: @mstidham, @thescurry do you guys experience the same?

[aksonov]

Oh, thanks, video is very helpful - i.e. it shows that address is shown correctly AFTER bot details UI loading! Probably address was not loaded during geolocation search, need to check.

[aksonov]

So should we merge related PR? An absence of the address looks not related to this ticket and should be ticketed separately. Looks like server geoquery API doesn't return address and should be fixed. But if we will switch to new API anyway (#1430), we just need to check 'address' is returned there.

[zavreb]

@aksonov spinoff #1506 created to check post new server geoquery API.

Re: this ticket

LGTM.

[mstidham]

Verified on Prod