Enable a verified icon for the following list #922

zavreb · 2017-06-21T23:08:53Z

GOAL: We want a verified icon for the accounts below:

REQs:

Please add the verified icon for the following accounts (cc: @bengtan)

@scurry
@tinyrobot
@Discover_UrCity
@explore_la
@thescenicroute
@ThereNBackAgain
@beckytravels

Please apply to the following screens:

Verified Account: User Profile

Verified Account: Followers Screen

Per previous confusion: There's no relationship between a verified account and the accounts that are being auto-followed.

zavreb · 2017-08-17T16:12:07Z

Needs more discussion per @thescurry

Estimate is based on server side flag.

zavreb · 2017-08-29T00:02:33Z

@thescurry is fine with this ticket.

southerneer · 2017-08-30T22:07:05Z

Still waiting on the back-end piece as far as I know. Right @bengtan ?

bengtan · 2017-08-31T05:39:04Z

@southerneer:

Yes, it's waiting on ...

Assign the role 'verified' to some accounts
hippware/wocky#912

but that's just a configuration change. It doesn't require a deploy so it should be implemented within the next 24 hours or so.

Keep in mind that, for testing purposes on Staging, I've only asked @bernardd to add verified to scurry, becky, and miranda. (See hippware/wocky#912)

If we want to mark any other Staging users as verified, please post to the server side ticket 912.

The documentation is https://github.com/hippware/tr-wiki/wiki/User#roles.

Effectively, you should be expecting this in the user xmpp element:

(from https://github.com/hippware/tr-wiki/wiki/User#get-simple-information)

        <field var='roles' type='roles'>
            <roles>
                <role>verified</role>
            </roles>
        </field>

bengtan · 2017-08-31T06:04:24Z

@zavreb,

@bernardd says there's no user named therenbackagain on Production.

bengtan · 2017-08-31T06:08:33Z

bernardd says there's no user named therenbackagain on Production.

False alarm. He found it.

bernardd · 2017-08-31T06:11:09Z

Capitalisation matters, people :)

bengtan · 2017-09-12T07:51:10Z

Uh, in case there was a loss in transmission ... the server side configuration for this is done and this ticket is no longer blocked.

(cc @zavreb, @southerneer)

zavreb · 2017-10-17T15:47:28Z

checking in...@southerneer this isn't based on user handle right?

bengtan · 2017-10-17T17:18:20Z

It's not.

The 'verified' field is injected by the server and the server uses the user id to decide whether to inject it.

In other words, it's based on the user id, not the handle. A user can change the user handle/username and it will have no effect on the badge.

bengtan · 2017-10-17T17:26:41Z

@southerneer:

@bernardd has modified a user on staging so it was two roles. The account is a4b48f7e-8f21-11e6-b86d-0e600a8611a9 (at-becky) on Staging.

zavreb · 2017-10-20T16:43:58Z

LGTM. Verified on Staging 1.56.0. Wrote a spinoff #1432 to adjust the logic a bit (for future's sake)

irfirl · 2017-10-20T16:48:05Z

Verified on Staging

zavreb · 2017-10-20T17:53:12Z

Sending this back for rework.

User only sees the verified icon when they tap into that verified user's profile. Please enable this without a user having to tap into a verified User Profile. While QAing, I thought the fix was only made for user: becky and didn't realize scurry had a verified icon...

southerneer · 2017-10-20T17:54:37Z

~~This may require a logout/login to see the verified icon everywhere since some of that data is cached. The reason you see it when clicking into their profile is because the info is pulled fresh.~~

Nm, I see that behavior too with a fresh install.

southerneer · 2017-10-20T22:39:18Z

Codepushed to "Staging". This should get applied in the background automatically. Just open the app once, wait for a minute, kill, reload. If it works then you'll see "1.56.0-922" as the version number in the bottom left of the side menu.

irfirl · 2017-10-20T22:40:25Z

Verified on Codepush

zavreb · 2017-10-23T17:52:51Z

Verified on Codepush.1.56.0-922

mstidham · 2017-10-27T17:06:10Z

Verified on Staging

irfirl · 2017-10-27T22:05:41Z

Verified on Staging

zavreb · 2017-10-27T22:42:35Z

Verified on Staging. Pushing ticket to "Verify on Prod"

mstidham · 2017-11-01T14:25:58Z

@Discover_UrCity, @tinyrobot, @explore_la, @ThereNBackAgain do not have the verified icon. I'm also assuming that @becky is @beckytravels.

zavreb · 2017-11-01T18:11:48Z

@mstidham yes, it's based on user id so even if we change our usernames we should still have verified icons.

zavreb · 2017-11-01T18:14:54Z

For the rest of the accounts, it's the whole, you have to tap into them to see the icon... I'm sure there was a ticket to fix this...

mm, can't find it...

mstidham · 2017-11-02T18:05:00Z

Need to verify this on Prod

zavreb · 2017-11-02T19:45:40Z

Need to verify this on Prod. Can't verify on staging.

mstidham · 2017-11-06T14:01:13Z

Verified on Prod

zavreb · 2017-11-09T21:56:01Z

Verified on Prod. Closing ticket.

zavreb added the enhancement label Jun 21, 2017

zavreb added this to the Sprint #12.1 milestone Jun 21, 2017

zavreb assigned irfirl Jun 21, 2017

bengtan mentioned this issue Jul 14, 2017

Assign the role 'staff' to some accounts hippware/wocky#840

Closed

zavreb modified the milestones: Sprint #13.1, Sprint #12.1 | Aug 04 - Aug 17 Aug 8, 2017

hippware deleted a comment from didilee Aug 16, 2017

zavreb unassigned irfirl Aug 16, 2017

zavreb changed the title ~~DRAFT - Enable a tinyrobot staff icon for staff accounts on TR~~ Enable a verified accounts icon for Verified Accounts on tinyrobot Aug 16, 2017

zavreb changed the title ~~Enable a verified accounts icon for Verified Accounts on tinyrobot~~ Enable a verified accounts icon for Group: Verified Accounts on tinyrobot Aug 16, 2017

zavreb changed the title ~~Enable a verified accounts icon for Group: Verified Accounts on tinyrobot~~ Enable a verified icon for Group: Auto-Follow Accounts on tinyrobot Aug 17, 2017

southerneer added the Blocked: Server Side label Aug 30, 2017

zavreb changed the title ~~Enable a verified icon for Group: Auto-Follow Accounts on tinyrobot~~ Enable a verified icon for the following list Aug 31, 2017

bengtan mentioned this issue Aug 31, 2017

Assign the role 'verified' to some accounts hippware/wocky#912

Closed

zavreb modified the milestones: Sprint #14.1 | Sept 1 - Sept 14, Sprint #13.1 | Aug. 18 - Aug. 31 Sep 1, 2017

southerneer removed the Blocked: Server Side label Sep 12, 2017

southerneer self-assigned this Sep 12, 2017

zavreb modified the milestones: Sprint #14.1 | Sept 1 - Sept 14, Sprint #13.1 | Aug. 18 - Aug. 31 Sep 12, 2017

southerneer pushed a commit that referenced this issue Oct 17, 2017

for #922. accounts for multiple roles

d6e8669

southerneer mentioned this issue Oct 17, 2017

Refactor: split BotInfo into sub-components. #1420

Merged

bengtan added a commit that referenced this issue Oct 17, 2017

Merge commit 'for #922. accounts for multiple roles'

8225be1

zavreb mentioned this issue Oct 20, 2017

Wherever a verified user appears, please append the verified icon #1432

Closed

zavreb added the REWORK label Oct 20, 2017

southerneer pushed a commit that referenced this issue Oct 20, 2017

for #922

6edf0b3

southerneer mentioned this issue Oct 20, 2017

Verified icon for event bot owners #1435

Merged

southerneer added the Codepush Deployed label Oct 20, 2017

southerneer mentioned this issue Nov 1, 2017

Verified icon: download extended user data once on friends/followers/following list #1476

Merged

zavreb closed this as completed Nov 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable a verified icon for the following list #922

Enable a verified icon for the following list #922

zavreb commented Jun 21, 2017 •

edited by southerneer

Loading

zavreb commented Aug 17, 2017 •

edited

Loading

zavreb commented Aug 29, 2017

southerneer commented Aug 30, 2017

bengtan commented Aug 31, 2017 •

edited

Loading

bengtan commented Aug 31, 2017

bengtan commented Aug 31, 2017

bernardd commented Aug 31, 2017

bengtan commented Sep 12, 2017

zavreb commented Oct 17, 2017

bengtan commented Oct 17, 2017

bengtan commented Oct 17, 2017

zavreb commented Oct 20, 2017 •

edited

Loading

irfirl commented Oct 20, 2017

zavreb commented Oct 20, 2017

southerneer commented Oct 20, 2017 •

edited

Loading

southerneer commented Oct 20, 2017

irfirl commented Oct 20, 2017 •

edited

Loading

zavreb commented Oct 23, 2017

mstidham commented Oct 27, 2017

irfirl commented Oct 27, 2017

zavreb commented Oct 27, 2017

mstidham commented Nov 1, 2017

zavreb commented Nov 1, 2017

zavreb commented Nov 1, 2017

mstidham commented Nov 2, 2017

zavreb commented Nov 2, 2017

mstidham commented Nov 6, 2017

zavreb commented Nov 9, 2017

Enable a verified icon for the following list #922

Enable a verified icon for the following list #922

Comments

zavreb commented Jun 21, 2017 • edited by southerneer Loading

Verified Account: User Profile

Verified Account: Followers Screen

zavreb commented Aug 17, 2017 • edited Loading

zavreb commented Aug 29, 2017

southerneer commented Aug 30, 2017

bengtan commented Aug 31, 2017 • edited Loading

bengtan commented Aug 31, 2017

bengtan commented Aug 31, 2017

bernardd commented Aug 31, 2017

bengtan commented Sep 12, 2017

zavreb commented Oct 17, 2017

bengtan commented Oct 17, 2017

bengtan commented Oct 17, 2017

zavreb commented Oct 20, 2017 • edited Loading

irfirl commented Oct 20, 2017

zavreb commented Oct 20, 2017

southerneer commented Oct 20, 2017 • edited Loading

southerneer commented Oct 20, 2017

irfirl commented Oct 20, 2017 • edited Loading

zavreb commented Oct 23, 2017

mstidham commented Oct 27, 2017

irfirl commented Oct 27, 2017

zavreb commented Oct 27, 2017

mstidham commented Nov 1, 2017

zavreb commented Nov 1, 2017

zavreb commented Nov 1, 2017

mstidham commented Nov 2, 2017

zavreb commented Nov 2, 2017

mstidham commented Nov 6, 2017

zavreb commented Nov 9, 2017

zavreb commented Jun 21, 2017 •

edited by southerneer

Loading

zavreb commented Aug 17, 2017 •

edited

Loading

bengtan commented Aug 31, 2017 •

edited

Loading

zavreb commented Oct 20, 2017 •

edited

Loading

southerneer commented Oct 20, 2017 •

edited

Loading

irfirl commented Oct 20, 2017 •

edited

Loading