Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wherever a verified user appears, please append the verified icon #1432

Closed
zavreb opened this issue Oct 20, 2017 · 9 comments
Closed

Wherever a verified user appears, please append the verified icon #1432

zavreb opened this issue Oct 20, 2017 · 9 comments
Assignees

Comments

@zavreb
Copy link

zavreb commented Oct 20, 2017

GOAL: In the future we may be changing screens constantly, therefore, it'll be harder to keep track of where to make sure the verified user icon appears...The logic doesn't appear for Bot List, but that's because it wasn't a requirement (not because it wasn't implemented)...thus as we move forward at startup speed, we need to make sure the logic is adjusted so that it is appended everywhere the verified user appears

REQs:

  • Please adjust logic so that wherever a verified user appears, the verified icon is appended (ensure it also appears on Bot List (My Bots and Saved Bots) and Messages (not a high priority since this whole feature will get reworked)
@zavreb
Copy link
Author

zavreb commented Oct 20, 2017

Related to #922

@southerneer
Copy link
Contributor

Another thing that will boost "startup speed" is trimming Github issues to only the necessary information to fulfill the requirement. The GOAL section is unnecessary especially for such a minor issue. @zavreb please just note the spots that were missed and save the extra commentary for Slack posts, wikis, and the like.

@zavreb
Copy link
Author

zavreb commented Oct 24, 2017

@southerneer noted.

@bengtan
Copy link
Contributor

bengtan commented Oct 24, 2017

trimming Github issues to only the necessary information to fulfill the requirement.

This applies to tickets which say 'Do XYZ'. It probably doesn't apply to bugs or tickets which say 'Investigate XYZ'.

cc @zavreb @southerneer

@southerneer
Copy link
Contributor

@bengtan Yes and no. Yes in that investigation tickets will be more wordy in general and will need some explanation of "why" in order to get to the "how". No in that process-related meta-commentary, while constructive in the abstract, belongs elsewhere in my opinion. At the very least limit the original post to the requirements and add the rest to a subsequent comment. Basically I'm just trying to strip away any unnecessary cognitive weight for these tickets that Pavel and I need to be able to look at and understand quickly in order to do our job effectively.

@zavreb
Copy link
Author

zavreb commented Oct 25, 2017

@southerneer lets discuss this further during our weekly meeting, to make sure we're getting everyone's feedback in

@zavreb zavreb removed this from the Sprint #17.1 | Oct 13 - Oct 26 milestone Oct 27, 2017
@zavreb
Copy link
Author

zavreb commented Oct 27, 2017

Deprioritizing... @thescurry we can speak further about this next week.

@thescurry
Copy link

@zavreb do we need to discuss this ticket today?

@zavreb
Copy link
Author

zavreb commented Dec 12, 2017

closing.

@zavreb zavreb closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants