Bot Edit Tweak: Discard changes for cover photo changes

[mstidham]

Title: Discard changes for cover photo changes

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus
iOS:	11.1.2
tr Version:	1.65.0
Environment	Staging
Codepush:	Staging-Pavel "uber panning #4"
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:
Bypass handle?:	@TestyTester
Location access type?	While Using
Does this issue occur on other environments?	Production
Time issue occurred (UTC)

Observed Result:

If a user adds a cover photo during bot edit, then taps back caret and receives Discard changes popup and selects Discard. The newly added cover image should be discarded.

Expected Result:

If user taps Discard on Discard changes popup, the newly added cover image should be discarded.

Steps to reproduce:

1. Add cover photo
2. Tap back caret
3. Receive popup
4. Tap Discard

[zavreb]

If this is a difficult fix, please let us know.

[southerneer]

Looks like a bug ticket but has the 'enhancement' label. Just to be clear, bot cover photos were specifically excluded as discard-able from the original ticket, correct?

[southerneer]

This would be a decent bit of work since we currently upload the image separately (instantly) from the rest of the bot info when editing.

[zavreb]

@southerneer I put enhancement instead of bug because it was never explicitly put as a requirement, I believe. Nonetheless, I can change it to bug 😉

I'd like to move this ticket to punt for q1 due to complexity. cc: @thescurry

[thescurry]

@southerneer @zavreb happy to sync on this one today and figure out the way forward (either doing it now or punting to Q1).

[southerneer]

@thescurry I think we were 2 ships passing in the night. Talk it over tomorrow?

[zavreb]

Dup of #1949, closing ticket