Bot Edit Tweak: Changing location saves even when user taps on discard changes

[mstidham]

Title: Changing location saves even when user taps on discard changes

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus
iOS:	11.1.2
tr Version:	1.65.0
Environment	Staging
Codepush:	Staging-Pavel "uber panning #4"
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:
Bypass handle?:	@TestyTester
Location access type?	While Using
Does this issue occur on other environments?
Time issue occurred (UTC)	7:07 PM

Observed Result:

A user changes the location on a bot and then backs out of the bot until they see Unsaved Changes Pop-up. User taps Discard and the changed location is saved.

Expected Result:

When user taps Discard on popup all changes to the bot should be discarded.

Steps to reproduce:

1. Edit a bot
2. Change location
3. Back caret out of bot edit until you see Unsaved Changes popup
4. Tap Discard

Related Screenshots/Video Links:

---

[zavreb]

This is due to some legacy code where changing cover image, note, and location automatically saved. It should no longer save since we implemented the discard changes. I understand this is not a bug @aksonov, @southerneer...

@mstidham to create a separate ticket to address cover photo changes. I believe note changes are no longer automatically saved.

[aksonov]

I can't reproduce.

P. S. @zavreb Actually "discard changes" is non-trivial separate ticket (original ticket was just about popup).

@southerneer Current implementation is not good (via global variable oldBot) - some bot changes may still be persistent after swipe or app kill/reload (until it is not reloaded from the server). Correct implementation is a little more complex - it is necessary to create botStore.bot as bot clone (like new Bot(bot)), edit that clone and only after "Save" change original bot.

[zavreb]

Punting to q1. To marry with #1661

[southerneer]

Add #1658 to that too plz.

[mstidham]

@zavreb I'm not seeing this issue on Production Version 1.65.3

[mstidham]

The changed address does not save when user taps discard. When user taps discard and goes back to bot profile the changed address does appear but reverts to the previous address when user leaves bot profile and then returns to bot profile.

[zavreb]

Dup of #1949 closing