Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# 8 Bot Edit: Tapping "<" & approving alert = Discard Changes #1563

Closed
4 tasks done
zavreb opened this issue Nov 21, 2017 · 10 comments
Closed
4 tasks done

# 8 Bot Edit: Tapping "<" & approving alert = Discard Changes #1563

zavreb opened this issue Nov 21, 2017 · 10 comments
Assignees

Comments

@zavreb
Copy link

zavreb commented Nov 21, 2017

Currently there is no way for a user to discard their changes when editing a bot (also applies to bot creation flow)

  • When a user is editing changes tapping < from this screen zpl.io/aRMvX4E, serve this alert zpl.io/25NZnY0
  • The only change that should automatically save is the cover photo, all note changes etc. cannot be saved after the user taps to discard changes
  • Please return them to the last screen they were on after they tap discard, if that is too difficult HS is fine
  • If user taps cancel keep them in the same screen

Tapping "<" ask user if they would like to discard changes

image

Bot Profile Edit State

image

@zavreb zavreb changed the title # 8 Bot Creation/Edit: Tapping "<" # 8 Bot Creation/Edit: Tapping "<" = Discard Changes Nov 21, 2017
@zavreb zavreb changed the title # 8 Bot Creation/Edit: Tapping "<" = Discard Changes # 8 Bot Creation/Edit: Tapping "<" & approving alert = Discard Changes Nov 21, 2017
@zavreb zavreb added this to the Sprint #20.1 | Nov 24 - Dec 7 milestone Nov 21, 2017
@southerneer
Copy link
Contributor

southerneer commented Nov 22, 2017

The user should not be able to return to the map view during bot creation

Please return them to the last screen they were on after they tap discard

In the case of bot creation (as opposed to editing) the previous screen is the map. So you mean return them to the screen before that?

rz: @southerneer correct.

@zavreb zavreb changed the title # 8 Bot Creation/Edit: Tapping "<" & approving alert = Discard Changes # 8 Bot Edit: Tapping "<" & approving alert = Discard Changes Nov 22, 2017
@zavreb
Copy link
Author

zavreb commented Nov 22, 2017

@southerneer please disregard my previous comments regarding bot creation. This should not happen during bot creation due to nav complications expressed during call.

@zavreb
Copy link
Author

zavreb commented Nov 22, 2017

Potential other ticket to lock screen and not allow gesture swiping.

@southerneer southerneer self-assigned this Dec 8, 2017
southerneer added a commit that referenced this issue Dec 11, 2017
@southerneer
Copy link
Contributor

codepushed to StagingEric

@zavreb
Copy link
Author

zavreb commented Dec 12, 2017

LGTM. Verified on prod 1.65.0 found a bug

Aware of the gesture issue, creating a related item on the roadmap for 2018.

@mstidham
Copy link

@zavreb is the back caret supposed to be pink as in the mock?

image

@zavreb
Copy link
Author

zavreb commented Dec 14, 2017

@mstidham lets keep it at gray. We don't want a strong call out to the "back" button.

Verified on 1.65.0 staging.

@zavreb
Copy link
Author

zavreb commented Dec 15, 2017

Verified on Staging 1.65.0

@mstidham
Copy link

Verified on Prod 1.65.1

1 similar comment
@zavreb
Copy link
Author

zavreb commented Dec 18, 2017

Verified on Prod 1.65.1

@zavreb zavreb closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants