Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove previewnet, testnet, mainnet configuration #659

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

natanasow
Copy link
Contributor

Description:

Remove previewnet, testnet, mainnet configuration for several reasons:

  1. They are unused from most, if not all users.
  2. It's almost as easier to start with whatever container you want, just by specifying using --network-tag or --mirror-tag or --relay-tag
  3. Because of them, we need to overide env. varibles, which create unnecessery complications when used in CI.

Related issue(s):

Fixes #589

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow self-assigned this Jun 19, 2024
@natanasow natanasow marked this pull request as ready for review June 19, 2024 10:02
@natanasow natanasow requested a review from leninmehedy June 19, 2024 10:02
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Copy link

Copy link
Contributor

@victor-yanev victor-yanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isavov isavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 👍 👨‍💻

Copy link
Member

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @natanasow

@natanasow natanasow merged commit b3d008f into main Jun 20, 2024
9 checks passed
@natanasow natanasow deleted the 589-remove-previewnet-testnet-mainnet-configurations branch June 20, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify network configurations
4 participants