-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record file debugging tool #217
Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
# Conflicts: # src/utils/cliOptions.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress, Good work.
cli.js
Outdated
@@ -62,6 +62,16 @@ yargs(hideBin(process.argv)) | |||
await HederaUtils.generateAccounts(console, argv.accounts); | |||
} | |||
) | |||
.command( | |||
"debug [timestamp]", | |||
"Parses and prints the contents of the record file that has been created during the selected timestamp [default: latest]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: doesn't work if no timestamp is passed or if latest is passed.
hedera-local-node % node cli.js debug
cli.js debug [timestamp]
Parses and prints the contents of the record file that has been created during
the selected timestamp [default: latest]
Options:
--help Show help [boolean]
--version Show version number [boolean]
--timestamp Record file timestamp [string] [required]
Missing required argument: timestamp
hedera-local-node % node cli.js debug latest
Invalid timestamp string. Accepted formats are: 0000000000.000000000 and 0000000000-000000000
hedera-local-node %
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tooltip was outdated. I decided against implementing the option to parse the latest record file, since that information wouldn't really be usefull due to the constant and fast creation of newer record files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Kudos, SonarCloud Quality Gate passed!
|
* Add smoke tests for each network Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Bump versions Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Fix local node occasionally fails to start (#203) * wait before generating accounts Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump sdk version Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump sdk version Signed-off-by: georgi-l95 <glazarov95@gmail.com> * test Signed-off-by: georgi-l95 <glazarov95@gmail.com> * check if network node is started Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> * Add environment readiness test flow (#188) Add environment readiness test flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> * Add feature flag for atomicCryptoTransfer (#210) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: nikolay <n.atanasow94@gmail.com> * bump version 2.1.3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> * feat: add a flag to control relay rate limit (#206) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: add option to enable dev mode (#214) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: add missing env vars (#221) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * Record file debugging tool (#217) * wip: add a record parsing command Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * wip: parse records from inside network node Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: temporarily add java build files Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: re-ignore compile directory Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: input validation Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: resolve code smells Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: debug tooltip Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: changed record file selection logic Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: load env vars at correct time Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * Official hedera explorer image (#222) * chore: bump version Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * update explorer image registry Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: nikolay <n.atanasow94@gmail.com> Co-authored-by: georgi-l95 <glazarov95@gmail.com>
* Add smoke tests for each network Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Bump versions Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Edit ci Signed-off-by: nikolay <n.atanasow94@gmail.com> * Fix local node occasionally fails to start (#203) * wait before generating accounts Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump sdk version Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump sdk version Signed-off-by: georgi-l95 <glazarov95@gmail.com> * test Signed-off-by: georgi-l95 <glazarov95@gmail.com> * check if network node is started Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> * Add environment readiness test flow (#188) Add environment readiness test flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> * Add feature flag for atomicCryptoTransfer (#210) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: nikolay <n.atanasow94@gmail.com> * bump version 2.1.3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> * feat: add a flag to control relay rate limit (#206) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: add option to enable dev mode (#214) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: add missing env vars (#221) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * Record file debugging tool (#217) * wip: add a record parsing command Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * wip: parse records from inside network node Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: temporarily add java build files Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code cleanup Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: re-ignore compile directory Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: input validation Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: resolve code smells Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: debug tooltip Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: changed record file selection logic Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: load env vars at correct time Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * Official hedera explorer image (#222) * chore: bump version Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * update explorer image registry Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * Fix ports mapping (#234) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: nikolay <n.atanasow94@gmail.com> * Bump the relay image version (#235) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: nikolay <n.atanasow94@gmail.com> * audit fix Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: nikolay <n.atanasow94@gmail.com> Co-authored-by: Ivo Yankov <ivo@devlabs.bg>
Description:
Adds a new command for reading the contents of a record file from a provided timestamp:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist