Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local node occasionally fails to start #203

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

georgi-l95
Copy link
Member

Description:

  • Bump Hedera SDK version
  • Add additional start check for network node

Related issue(s):

Fixes #191

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 added Bug An error that causes the feature to behave differently than what was expected based on design. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. labels Oct 25, 2022
@georgi-l95 georgi-l95 self-assigned this Oct 25, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@georgi-l95 georgi-l95 marked this pull request as ready for review October 25, 2022 08:26
Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@georgi-l95 georgi-l95 merged commit ce77833 into develop Oct 25, 2022
@georgi-l95 georgi-l95 deleted the 191-starting-node-occasionally-fails branch October 25, 2022 08:46
georgi-l95 added a commit that referenced this pull request Oct 25, 2022
* Fix local node occasionally fails to start (#203)

* wait before generating accounts

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* check if network node is started

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95 added a commit that referenced this pull request Oct 28, 2022
* Add smoke tests for each network

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Bump versions

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Fix local node occasionally fails to start (#203)

* wait before generating accounts

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* check if network node is started

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add environment readiness test flow (#188)

Add environment readiness test flow

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add feature flag for atomicCryptoTransfer (#210)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* bump version 2.1.3

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Co-authored-by: nikolay <n.atanasow94@gmail.com>
Ivo-Yankov pushed a commit that referenced this pull request Nov 7, 2022
* Fix local node occasionally fails to start (#203)

* wait before generating accounts

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* check if network node is started

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Kalina-Todorova pushed a commit that referenced this pull request Nov 17, 2022
* Add smoke tests for each network

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Bump versions

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Fix local node occasionally fails to start (#203)

* wait before generating accounts

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* check if network node is started

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add environment readiness test flow (#188)

Add environment readiness test flow

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add feature flag for atomicCryptoTransfer (#210)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* bump version 2.1.3

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* feat: add a flag to control relay rate limit (#206)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* feat: add option to enable dev mode (#214)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: add missing env vars (#221)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* Record file debugging tool (#217)

* wip: add a record parsing command

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* wip: parse records from inside network node

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: temporarily add java build files

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: code cleanup

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: re-ignore compile directory

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* feat: input validation

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* nit: resolve code smells

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: debug tooltip

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: changed record file selection logic

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: load env vars at correct time

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* Official hedera explorer image (#222)

* chore: bump version

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* update explorer image registry

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Co-authored-by: nikolay <n.atanasow94@gmail.com>
Co-authored-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95 added a commit that referenced this pull request Dec 2, 2022
* Add smoke tests for each network

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Bump versions

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Edit ci

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Fix local node occasionally fails to start (#203)

* wait before generating accounts

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* bump sdk version

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* check if network node is started

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add environment readiness test flow (#188)

Add environment readiness test flow

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* Add feature flag for atomicCryptoTransfer (#210)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* bump version 2.1.3

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* feat: add a flag to control relay rate limit (#206)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* feat: add option to enable dev mode (#214)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: add missing env vars (#221)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* Record file debugging tool (#217)

* wip: add a record parsing command

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* wip: parse records from inside network node

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: temporarily add java build files

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: code cleanup

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* chore: re-ignore compile directory

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* feat: input validation

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* nit: resolve code smells

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: debug tooltip

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: changed record file selection logic

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* fix: load env vars at correct time

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* Official hedera explorer image (#222)

* chore: bump version

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* update explorer image registry

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>

* Fix ports mapping (#234)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* Bump the relay image version (#235)

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* audit fix

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Co-authored-by: nikolay <n.atanasow94@gmail.com>
Co-authored-by: Ivo Yankov <ivo@devlabs.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants