Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-15634 Lazy basic property does not get updated on change #5461

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

dreab8
Copy link
Contributor

@dreab8 dreab8 commented Oct 27, 2022

Copy link
Contributor

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that you accidently also fixed https://hibernate.atlassian.net/browse/HHH-10747 since a failure expected test org.hibernate.orm.test.bytecode.enhancement.lazy.LazyLoadingByEnhancerSetterTest is now running through 😄

// we add also all the non lazy properties because dynamic update is false
for ( int i = 0; i < propertyLaziness.length; i++ ) {
if ( propertyLaziness[i] == false ) {
propsToUpdate[i] = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a quick discussion about this next week with @sebersole to hear his thoughts on this topic.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the reproducer in Quarkus (quarkusio/quarkus#28881) against Hibernate ORM 5.6 compiled with a backport of this patch (#5465), and I confirm it fixes all issues.

Thanks a lot @dreab8!

@dreab8
Copy link
Contributor Author

dreab8 commented Oct 28, 2022

@beikov gave me a huge help :) by the way we have to check that the call of the InlineDirtyCheckerEqualsHelper does not create any issue

@yrodiere
Copy link
Member

Then thanks to @beikov too :)

@beikov beikov merged commit 90b1cfe into hibernate:main Oct 31, 2022
@beikov beikov deleted the HHH-15634 branch October 31, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants