-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-15634 Lazy basic property does not get updated on change #5461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that you accidently also fixed https://hibernate.atlassian.net/browse/HHH-10747 since a failure expected test org.hibernate.orm.test.bytecode.enhancement.lazy.LazyLoadingByEnhancerSetterTest
is now running through 😄
// we add also all the non lazy properties because dynamic update is false | ||
for ( int i = 0; i < propertyLaziness.length; i++ ) { | ||
if ( propertyLaziness[i] == false ) { | ||
propsToUpdate[i] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have a quick discussion about this next week with @sebersole to hear his thoughts on this topic.
…dirty checking, lazy basic properties are not upated when set to null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the reproducer in Quarkus (quarkusio/quarkus#28881) against Hibernate ORM 5.6 compiled with a backport of this patch (#5465), and I confirm it fixes all issues.
Thanks a lot @dreab8!
@beikov gave me a huge help :) by the way we have to check that the call of the |
Then thanks to @beikov too :) |
https://hibernate.atlassian.net/browse/HHH-15634