Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate ORM to 5.6.14.Final and ByteBuddy to 1.12.18, add test for HHH-15634 #28881

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Oct 27, 2022

cc @gsmet

Creating as draft because the tests will fail until HHH-15634 gets fixed and we upgrade our Hibernate ORM dependency.

This will be useful to test the patch that @dreab8 is currently working on for Hibernate ORM.

To launch the test, build Quarkus, then run:

mvn clean test -pl extensions/hibernate-orm/deployment -Dtest='LazyBasic*'

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 27, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2022

/cc @Sanne, @gsmet

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Nov 3, 2022
@Sanne
Copy link
Member

Sanne commented Nov 3, 2022

Updated

@Sanne Sanne marked this pull request as ready for review November 3, 2022 21:20
@Sanne Sanne added triage/waiting-for-ci Ready to merge when CI successfully finishes priority/urgent labels Nov 3, 2022
@quarkus-bot

This comment has been minimized.

@Sanne Sanne changed the title Tests for HHH-15634 Lazy basic property does not get updated on change Upgrade Hibernate ORM, and test for HHH-15634 Nov 3, 2022
@Sanne
Copy link
Member

Sanne commented Nov 3, 2022

Incorporated the ORM release; for detailed changes see https://in.relation.to/2022/11/03/hibernate-orm-5613/

Sanne
Sanne previously requested changes Nov 3, 2022
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quarkus-bot

This comment has been minimized.

@geoand geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 4, 2022
@Sanne
Copy link
Member

Sanne commented Nov 4, 2022

Upgraded now to 5.6.14.Final to fix the Envers releated failures.

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 4, 2022
@quarkus-bot

This comment has been minimized.

@gsmet gsmet changed the title Upgrade Hibernate ORM, and test for HHH-15634 Upgrade Hibernate ORM to 5.6.14.Final and ByteBuddy to 1.12.18, add test for HHH-15634 Nov 4, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2022

Failing Jobs - Building ea5960b

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/logging-gelf 

📦 integration-tests/logging-gelf

io.quarkus.logging.gelf.it.GelfLogHandlerTest.test line 32 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.logging.gelf.it.GelfLogHandlerTest expected: not <null> within 40 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@Sanne
Copy link
Member

Sanne commented Nov 5, 2022

That's looking much better. Thanks all!

@Sanne Sanne merged commit 622dd40 into quarkusio:main Nov 5, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 5, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 5, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 5, 2022
@gsmet gsmet modified the milestones: 2.14.1.Final, 2.13.4.Final Nov 5, 2022
@yrodiere yrodiere deleted the HHH-15634 branch August 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE priority/urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants