Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在自动审核模式中,上线工单存在检测错误或警告时,并匹配auto_rwview_wrong参数时,工单状态应为自动审核不通过;在客户端JS脚本中增加脚本错误数的判断 #2692

Closed
wants to merge 21 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
所有工单都按照同样的逻辑处理
  • Loading branch information
peixubin committed Jul 3, 2024
commit b24e99ab0cfd7badd127470159a92a09543bc805
1 change: 0 additions & 1 deletion sql/utils/workflow_audit.py
Original file line number Diff line number Diff line change
@@ -238,7 +238,6 @@ def is_auto_review(self) -> bool:

def generate_audit_setting(self) -> AuditSetting:
if self.is_auto_review():
if self.workflow_type in [WorkflowType.SQL_REVIEW, WorkflowType.QUERY]:
if self.workflow.status != "workflow_autoreviewwrong":
return AuditSetting(auto_pass=True)