test: fix integration tests relying on specific byte amounts #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests for the volume resize feature rely on specific byte amounts that a ext4 filesystem on a fake block device has. The specific amounts recently changed, probably through a new version of mkfs.ext4. This amount equals the values from our GitHub Actions pipeline, as well as my local machine. The amounts might need to be changed again in the future if the tests start failing again, we might consider removing tests for the specific amounts, and just check that the resized number is larger than the initial if this happens often.
|
@apricote Interesting. Didn't think of that back then when I wrote that code. Another idea to relax the test is to just look at the ratio between new and old size, round it and expect it to equal 2. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests for the volume resize feature rely on specific byte amounts that a ext4 filesystem on a fake block device has. The specific amounts recently changed, probably through a new version of mkfs.ext4.
This amount equals the values from our GitHub Actions pipeline, as well as my local machine.
The amounts might need to be changed again in the future if the tests start failing again, we might consider removing tests for the specific amounts, and just check that the resized number is larger than the initial if this happens often.