Skip to content

Commit

Permalink
test: fix integration tests relying on specific byte amounts
Browse files Browse the repository at this point in the history
The integration tests for the volume resize feature rely on specific byte
amounts that a ext4 filesystem on a fake block device has. The specific
amounts recently changed, probably through a new version of mkfs.ext4.

This amount equals the values from our GitHub Actions pipeline, as well
as my local machine.

The amounts might need to be changed again in the future if the tests start
failing again, we might consider removing tests for the specific amounts,
and just check that the resized number is larger than the initial if this
happens often.
  • Loading branch information
apricote authored and LKaemmerling committed Nov 11, 2022
1 parent 7901dd9 commit 44b31b6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions integrationtests/volumes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ func TestVolumeResize(t *testing.T) {
initialSize int
finalSize int
}{
{"plain", "", 26609, 57317},
{"encrypted", "passphrase", 27761, 58597},
{"plain", "", 25844, 56042},
{"encrypted", "passphrase", 27044, 57402},
}

for _, test := range tests {
Expand Down

0 comments on commit 44b31b6

Please sign in to comment.