Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.2.6.8 #4324

Merged
merged 6 commits into from
Dec 10, 2024
Merged

v.2.6.8 #4324

merged 6 commits into from
Dec 10, 2024

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Dec 10, 2024

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced components with improved styling options and visual indicators for deprecated attributes.
    • Added mobile device detection and improved event handling for buttons and links.
  • Bug Fixes

    • Resolved issues where interactive elements did not respond to the "onClick" event across various components.
  • Documentation

    • Updated documentation for multiple components to clarify event handling and usage instructions.
  • Chores

    • Incremented version numbers and updated dependency versions across multiple packages to ensure compatibility.

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 31ab508

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:00pm
nextui-storybook-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:00pm

Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes to various components and workflows within the project. Key modifications include enhancements to the release workflow for better error handling and control flow, updates to documentation for several components, and the deprecation of the onClick event in favor of onPress. Additionally, multiple packages have had their version numbers incremented, reflecting updates to dependencies and fixes for interactive elements not responding to events. These changes aim to improve robustness, usability, and maintainability across the codebase.

Changes

File Path Change Summary
.github/workflows/release.yaml Updated error handling and control flow; build step now terminates on failure; conditional steps for release and canary releases based on build success.
apps/docs/components/mdx-components.tsx Enhanced InlineCodeChip and APITable components; added className prop and deprecated field in data structure.
apps/docs/content/docs/components/button.mdx Marked onClick as deprecated; updated default value for radius attribute.
apps/docs/content/docs/components/dropdown.mdx Marked onClick as deprecated; expanded documentation on props and events.
apps/docs/content/docs/components/link.mdx Marked onClick as deprecated; added import statement for linkContent.
apps/docs/content/docs/components/listbox.mdx Updated installation instructions; added examples and new props; marked onClick as deprecated.
packages/components/accordion/CHANGELOG.md Updated to version 2.2.5; documented dependency updates.
packages/components/accordion/package.json Version updated from 2.2.4 to 2.2.5.
packages/components/alert/CHANGELOG.md Updated to version 2.2.7; documented dependency updates.
packages/components/alert/package.json Version updated from 2.2.6 to 2.2.7.
packages/components/autocomplete/CHANGELOG.md Updated to version 2.3.7; documented dependency updates.
packages/components/autocomplete/package.json Version updated from 2.3.6 to 2.3.7.
packages/components/button/CHANGELOG.md Updated to version 2.2.7; documented fix for onClick event issue.
packages/components/button/__tests__/button.test.tsx Added test case for onClick function.
packages/components/button/package.json Version updated from 2.2.6 to 2.2.7.
packages/components/button/src/use-button.ts Marked onClick as deprecated in Props interface.
packages/components/button/stories/button.stories.tsx Updated handlePress function signature for event logging.
packages/components/calendar/CHANGELOG.md Updated to version 2.2.7; documented dependency updates.
packages/components/calendar/package.json Version updated from 2.2.6 to 2.2.7.
packages/components/card/CHANGELOG.md Updated to version 2.2.7; documented fix for onClick event issue.
packages/components/card/__tests__/card.test.tsx Added test case for onClick function.
packages/components/card/package.json Version updated from 2.2.6 to 2.2.7.
packages/components/card/src/use-card.ts Updated Props interface to deprecate onClick.
packages/components/card/stories/card.stories.tsx Added PressableTemplate for interactive card examples.
packages/components/date-picker/CHANGELOG.md Updated to version 2.3.7; documented dependency updates.
packages/components/date-picker/package.json Version updated from 2.3.6 to 2.3.7.
packages/components/drawer/CHANGELOG.md Updated to version 2.2.5; documented dependency updates.
packages/components/drawer/package.json Version updated from 2.2.4 to 2.2.5.
packages/components/dropdown/CHANGELOG.md Updated to version 2.3.7; documented fix for onClick event issue.
packages/components/dropdown/package.json Version updated from 2.3.6 to 2.3.7.
packages/components/link/CHANGELOG.md Updated to version 2.2.5; documented fix for onClick event issue.
packages/components/link/__tests__/link.test.tsx Added tests for onClick and onPress functions.
packages/components/link/package.json Version updated from 2.2.4 to 2.2.5.
packages/components/listbox/CHANGELOG.md Updated to version 2.3.7; documented fix for onClick event issue.
packages/components/listbox/package.json Version updated from 2.3.6 to 2.3.7.
packages/components/menu/CHANGELOG.md Updated to version 2.2.7; documented fix for onClick event issue.
packages/components/menu/package.json Version updated from 2.2.6 to 2.2.7; removed @nextui-org/use-aria-menu dependency.
packages/hooks/use-aria-button/CHANGELOG.md Updated to version 2.2.3; documented fix for onClick event issue.
packages/hooks/use-aria-button/package.json Version updated from 2.2.2 to 2.2.3; added @nextui-org/shared-utils dependency.

Possibly related PRs

Suggested labels

🚥 Status: On Hold

Suggested reviewers

  • wingkwong

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3f119d9 and 31ab508.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (82)
  • .github/workflows/release.yaml (2 hunks)
  • apps/docs/components/mdx-components.tsx (3 hunks)
  • apps/docs/content/docs/components/button.mdx (1 hunks)
  • apps/docs/content/docs/components/dropdown.mdx (1 hunks)
  • apps/docs/content/docs/components/link.mdx (1 hunks)
  • apps/docs/content/docs/components/listbox.mdx (1 hunks)
  • packages/components/accordion/CHANGELOG.md (1 hunks)
  • packages/components/accordion/package.json (1 hunks)
  • packages/components/alert/CHANGELOG.md (1 hunks)
  • packages/components/alert/package.json (1 hunks)
  • packages/components/autocomplete/CHANGELOG.md (1 hunks)
  • packages/components/autocomplete/package.json (1 hunks)
  • packages/components/button/CHANGELOG.md (1 hunks)
  • packages/components/button/__tests__/button.test.tsx (2 hunks)
  • packages/components/button/package.json (1 hunks)
  • packages/components/button/src/use-button.ts (2 hunks)
  • packages/components/button/stories/button.stories.tsx (1 hunks)
  • packages/components/calendar/CHANGELOG.md (1 hunks)
  • packages/components/calendar/package.json (1 hunks)
  • packages/components/card/CHANGELOG.md (1 hunks)
  • packages/components/card/__tests__/card.test.tsx (2 hunks)
  • packages/components/card/package.json (1 hunks)
  • packages/components/card/src/use-card.ts (3 hunks)
  • packages/components/card/stories/card.stories.tsx (2 hunks)
  • packages/components/date-picker/CHANGELOG.md (1 hunks)
  • packages/components/date-picker/package.json (1 hunks)
  • packages/components/drawer/CHANGELOG.md (1 hunks)
  • packages/components/drawer/package.json (1 hunks)
  • packages/components/dropdown/CHANGELOG.md (1 hunks)
  • packages/components/dropdown/package.json (1 hunks)
  • packages/components/dropdown/stories/dropdown.stories.tsx (1 hunks)
  • packages/components/link/CHANGELOG.md (1 hunks)
  • packages/components/link/__tests__/link.test.tsx (2 hunks)
  • packages/components/link/package.json (1 hunks)
  • packages/components/link/src/use-link.ts (2 hunks)
  • packages/components/link/stories/link.stories.tsx (3 hunks)
  • packages/components/listbox/CHANGELOG.md (1 hunks)
  • packages/components/listbox/package.json (1 hunks)
  • packages/components/listbox/src/base/listbox-item-base.tsx (1 hunks)
  • packages/components/listbox/src/use-listbox-item.ts (4 hunks)
  • packages/components/listbox/stories/listbox.stories.tsx (1 hunks)
  • packages/components/menu/CHANGELOG.md (1 hunks)
  • packages/components/menu/__tests__/menu.test.tsx (3 hunks)
  • packages/components/menu/package.json (1 hunks)
  • packages/components/menu/src/base/menu-item-base.tsx (2 hunks)
  • packages/components/menu/src/menu.tsx (0 hunks)
  • packages/components/menu/src/use-menu-item.ts (5 hunks)
  • packages/components/menu/src/use-menu.ts (1 hunks)
  • packages/components/menu/stories/menu.stories.tsx (1 hunks)
  • packages/components/modal/CHANGELOG.md (1 hunks)
  • packages/components/modal/package.json (1 hunks)
  • packages/components/navbar/CHANGELOG.md (1 hunks)
  • packages/components/navbar/package.json (2 hunks)
  • packages/components/navbar/src/navbar-menu-toggle.tsx (1 hunks)
  • packages/components/popover/CHANGELOG.md (1 hunks)
  • packages/components/popover/package.json (1 hunks)
  • packages/components/select/CHANGELOG.md (1 hunks)
  • packages/components/select/package.json (1 hunks)
  • packages/components/slider/CHANGELOG.md (1 hunks)
  • packages/components/slider/package.json (1 hunks)
  • packages/components/snippet/CHANGELOG.md (1 hunks)
  • packages/components/snippet/package.json (1 hunks)
  • packages/components/tabs/CHANGELOG.md (1 hunks)
  • packages/components/tabs/package.json (1 hunks)
  • packages/components/tooltip/CHANGELOG.md (1 hunks)
  • packages/components/tooltip/package.json (1 hunks)
  • packages/core/react/CHANGELOG.md (1 hunks)
  • packages/core/react/package.json (1 hunks)
  • packages/hooks/use-aria-button/CHANGELOG.md (1 hunks)
  • packages/hooks/use-aria-button/package.json (2 hunks)
  • packages/hooks/use-aria-button/src/index.ts (4 hunks)
  • packages/hooks/use-aria-link/CHANGELOG.md (1 hunks)
  • packages/hooks/use-aria-link/package.json (2 hunks)
  • packages/hooks/use-aria-link/src/index.ts (3 hunks)
  • packages/hooks/use-aria-menu/CHANGELOG.md (0 hunks)
  • packages/hooks/use-aria-menu/README.md (0 hunks)
  • packages/hooks/use-aria-menu/package.json (0 hunks)
  • packages/hooks/use-aria-menu/src/index.ts (0 hunks)
  • packages/hooks/use-aria-menu/src/use-menu-item.ts (0 hunks)
  • packages/hooks/use-aria-menu/src/use-menu.ts (0 hunks)
  • packages/hooks/use-aria-menu/tsconfig.json (0 hunks)
  • packages/hooks/use-aria-modal-overlay/CHANGELOG.md (1 hunks)
⛔ Files not processed due to max files limit (10)
  • packages/hooks/use-aria-modal-overlay/package.json
  • packages/hooks/use-aria-modal-overlay/src/index.ts
  • packages/hooks/use-aria-toggle-button/CHANGELOG.md
  • packages/hooks/use-aria-toggle-button/README.md
  • packages/hooks/use-aria-toggle-button/package.json
  • packages/hooks/use-aria-toggle-button/src/index.ts
  • packages/hooks/use-aria-toggle-button/tsconfig.json
  • packages/utilities/aria-utils/CHANGELOG.md
  • packages/utilities/aria-utils/package.json
  • packages/utilities/aria-utils/src/overlays/ariaHideOutside.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants