ci: when build fail will exit the release process #4319
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request modifies the release workflow configuration in Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/release.yaml (2)
30-37: Simplify the build step while maintaining error visibilityWhile the error handling is good, we can simplify this without losing the error information.
Consider this simpler approach:
- name: Build id: build - continue-on-error: false - # Custom turbo build failure information run: | - pnpm build || { - echo "Turbo build failed with exit code $?" - exit 1 - } + echo "::group::Build Output" + pnpm build + echo "::endgroup::"The
continue-on-error: falseis redundant as it's the default behavior. GitHub Actions will automatically show the exit code and error information. Using group commands improves log readability.
Line range hint
30-55: Well-structured fail-fast implementation for the release processThe changes implement a robust fail-fast approach in the release workflow:
- Early failure detection in the build step
- Proper step dependency chain using build status
- Consistent error handling across both regular and canary releases
This creates a more reliable release process by preventing potentially broken releases from being published.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/release.yaml(2 hunks)
🔇 Additional comments (2)
.github/workflows/release.yaml (2)
40-41: LGTM! Good safety check implementation
The condition steps.build.outcome == 'success' is a crucial safety measure that ensures the release process only continues if the build succeeds. This directly addresses the PR's objective.
55-55: Verify if the 15-minute timeout is sufficient
The condition steps.build.outcome == 'success' && steps.changesets.outputs.published != 'true' is correct, but let's verify if the 15-minute timeout is adequate for canary releases.
✅ Verification successful
Let me analyze the workflow durations:
- Run 1: 8 minutes 5 seconds (14:29:25 to 14:37:30)
- Run 2: 6 minutes 11 seconds (14:21:50 to 14:28:01)
- Run 3: 3 minutes 13 seconds (13:50:33 to 13:53:46)
- Run 4: 11 minutes 59 seconds (13:26:12 to 13:38:11)
- Run 5: 6 minutes 15 seconds (13:25:56 to 13:32:11)
Let me check if there's a timeout configuration in the workflow:
15-minute timeout is sufficient for canary releases
Based on the analysis of recent workflow runs, the longest execution took approximately 12 minutes, which is well within the 15-minute timeout limit. The average duration is around 7 minutes, providing adequate buffer for normal variations in build times.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check recent workflow runs to analyze build durations
gh api -X GET /repos/nextui-org/nextui/actions/workflows/release.yaml/runs \
--jq '.workflow_runs[0:5] | .[] | {status: .status, conclusion: .conclusion, duration: .updated_at, created_at: .created_at}'
Length of output: 782
Script:
#!/bin/bash
# Check for timeout configurations in the workflow
rg "timeout-minutes" .github/workflows/release.yaml
Length of output: 103
* ci: when build fail will exit the release process (#4319) * fix: on click event on interactive elements (#4322) * chore: deprecated style added to api table * ci(changesets): version packages (#4323) Co-authored-by: Junior Garcia <jrgarciadev@gmail.com> --------- Co-authored-by: winches <329487092@qq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit