Increase default Ruby version to 2.7.4 #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/ruby-2.7.4
branch
from
61cf080 to
d7a6756
Compare
Our policy is to stay on the latest patch release of the middle supported Ruby version. Supported versions are 3.0, 2.7, and 2.6 so the latest of the 2.7 is 2.7.4.
schneems
force-pushed
the
schneems/ruby-2.7.4
branch
from
d7a6756 to
427268d
Compare
SimpleDelegator was removed from being auto-required in Ruby 2.7 https://stackoverflow.com/questions/60459709/where-is-simpledelegator-in-ruby-2-7
- rspec ./spec/hatchet/rails5_spec.rb:46 # Rails 5.1 with webpacker calls bin/yarn no matter what is on the path
- Hatchet::Runner.new("rails51_webpacker").tap do |app|
- Test does not rely on Rails 5 specific behavior
- rspec ./spec/hatchet/rails5_spec.rb:4 # Rails 5 works
- Hatchet::Runner.new("rails5", stack: "heroku-18").deploy do |app, heroku|
- Version of Rails does not work with Ruby 2.7.4
- Not rails 5 specific, upgrading to Rails 6
- rspec ./spec/hatchet/bugs_spec.rb:12 # Bugs database connections fails with better error message
- Hatchet::Runner.new("connect_to_database_on_first_push", allow_failure: true).deploy do |app|
- We can use a generic/maintained app instead and inject the database connection code.
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley
added a commit
that referenced
this pull request
Sep 29, 2021
* Moves the entry for #1193 to "unreleased", since it was not part of the v229 release. * Fixes the date for the v229 release (it was published to the buildpack registry on `2021-08-30T15:57:32.024Z`). * Turns the `Main` heading into an H2 so it's at the same heading level as the versioned headings.
edmorley
reviewed
Sep 29, 2021
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## v229 (7/30/2021) | |||
|
|
|||
| * Default Ruby version is now 2.7.4 (https://github.com/heroku/heroku-buildpack-ruby/pull/1193) | |||
There was a problem hiding this comment.
This happened on a rebase perhaps? If we put effort into productizing our changelog check it would be nice to optionally enforce:
- Entry must be in the "unreleased" section (with optional over-ride)
- Entry dates in headers must be added with the current date (with optional over-ride)
- Maybe more
Thanks for spotting this!
There was a problem hiding this comment.
I missed it in my review, so my bad!
schneems
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Moves the entry for #1193 to "unreleased", since it was not part of the v229 release. * Fixes the date for the v229 release (it was published to the buildpack registry on `2021-08-30T15:57:32.024Z`). * Turns the `Main` heading into an H2 so it's at the same heading level as the versioned headings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our policy is to stay on the latest patch release of the middle supported Ruby version. Supported versions are 3.0, 2.7, and 2.6 so the latest of the 2.7 is 2.7.4.
GUS-W-9831879