Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lint configuration changed to scan JS files too #354

Merged
merged 1 commit into from
Jan 26, 2022
Merged

feat: lint configuration changed to scan JS files too #354

merged 1 commit into from
Jan 26, 2022

Conversation

njmulsqb
Copy link
Contributor

Fixes #349

@EvanHahn
Copy link
Member

Thanks! I'll take a look at this soon.

Just to double-check: what happens if you introduce a lint error in a .js file in the bin folder?

@njmulsqb
Copy link
Contributor Author

njmulsqb commented Jan 24, 2022 •
edited
Loading

Thanks! I'll take a look at this soon.

Just to double-check: what happens if you introduce a lint error in a .js file in the bin folder?

I have introduced an unused variable error in one file in bin then npm run lint throws error

@EvanHahn
Copy link
Member

Great! I plan to review in the next few days.

EvanHahn
EvanHahn approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

Feel free to add yourself to the contributors list if you like!

@EvanHahn EvanHahn merged commit 30b39ca into helmetjs:main Jan 26, 2022
@njmulsqb njmulsqb deleted the lintJSFiles branch January 26, 2022 15:38
@njmulsqb
Copy link
Contributor Author

Looks great! Thanks.

Feel free to add yourself to the contributors list if you like!

I am up for open source work on this project, currently issue seems more to be feedback oriented or they require information. If you come across some coding related work dont hesitate to ping me.

Thanks

@EvanHahn
Copy link
Member

EvanHahn commented Jan 26, 2022 via email

@njmulsqb njmulsqb mentioned this pull request Jan 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHahn EvanHahn EvanHahn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check .js files with ESLint
2 participants
@njmulsqb @EvanHahn