Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node 18+ #444

Closed
3 tasks done
EvanHahn opened this issue Oct 25, 2023 · 5 comments · Fixed by #450
Closed
3 tasks done

Require Node 18+ #444

EvanHahn opened this issue Oct 25, 2023 · 5 comments · Fixed by #450
Assignees
@njmulsqb
Milestone
v8.0.0

Comments

@EvanHahn
Copy link
Member

EvanHahn commented Oct 25, 2023 •
edited
Loading

Node 16 is no longer supported. Helmet v8 should drop support too.

Required subtasks:

  • Update the engines field of package.json
  • Remove old Node versions from CI configuration (bbcefa3)
  • Update the changelog
@EvanHahn EvanHahn added this to the v8.0.0 milestone Oct 25, 2023
@njmulsqb
Copy link
Contributor

njmulsqb commented Jan 8, 2024 •
edited
Loading

Hi @EvanHahn,

I am willing to work on this, can you tell me how much effort is required on this?

I have contributed to this package in the past: #354

@EvanHahn
Copy link
Member Author

EvanHahn commented Jan 8, 2024

The required subtasks are written in the description. I estimate <30 minutes of work.

Please make your change against the v8.0.0 branch. Let me know if I can help with anything!

@njmulsqb
Copy link
Contributor

njmulsqb commented Jan 9, 2024 •
edited
Loading

Alright, can I get my NPM account under "Collaborators" on https://www.npmjs.com/package/helmet after working on this issue?

@EvanHahn
Copy link
Member Author

EvanHahn commented Jan 9, 2024

I don't usually add people there, but I add lots of people to the contributors list on the Helmet website. Feel free to add your name there after you make your change!

@njmulsqb njmulsqb mentioned this issue Jan 10, 2024
Merged
@EvanHahn EvanHahn linked a pull request Jan 10, 2024 that will close this issue
update engine and changelog #450
Merged
EvanHahn added a commit that referenced this issue Jan 18, 2024
@njmulsqb @EvanHahn
Require Node 18+
442992b 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
@EvanHahn
Copy link
Member Author

Completed in #450. Thanks, @njmulsqb!

EvanHahn added a commit that referenced this issue Jan 22, 2024
@njmulsqb @EvanHahn
Require Node 18+
77d93ef 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
@2lambda123 2lambda123 mentioned this issue Jan 23, 2024
Merged
7 tasks
EvanHahn added a commit that referenced this issue Feb 17, 2024
@njmulsqb @EvanHahn
Require Node 18+
6be929e 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue Feb 17, 2024
@njmulsqb @EvanHahn
Require Node 18+
216cb65 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue Apr 27, 2024
@njmulsqb @EvanHahn
Require Node 18+
1a20f81 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue Apr 27, 2024
@njmulsqb @EvanHahn
Require Node 18+
394ba47 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue Apr 28, 2024
@njmulsqb @EvanHahn
Require Node 18+
f3e5941 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue May 25, 2024
@njmulsqb @EvanHahn
Require Node 18+
9c8553e 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
EvanHahn added a commit that referenced this issue Jun 1, 2024
@njmulsqb @EvanHahn
Require Node 18+
1da5a5d 
See [#444][0] and [#450][1].

[0]: #444
[1]: #450

Signed-off-by: Najam Ul Saqib <najamulsaqib@tutamail.com>
Co-authored-by: Evan Hahn <me@evanhahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njmulsqb njmulsqb

Labels
None yet
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

update engine and changelog njmulsqb/helmet
2 participants
@EvanHahn @njmulsqb