[stable/cluster-autoscaler] support dnsPolicy #9029

so0k · 2018-11-06T05:19:04Z

cluster-autoscaler should not rely on kube-dns see kubernetes/kops#1796 (comment)

This allows users to change the dnsPolicy: "Default" alleviating load on kube-dns / CoreDNS

Checklist

DCO signed
Chart Version bumped to 0.13.1
Variables are documented in the README.md

Signed-off-by: swo0k <vincentdesmet@swatmobile.io>

so0k · 2018-11-06T05:30:25Z

/assign @linki

davidkarlsen · 2018-11-06T10:08:23Z

/ok-to-test

Signed-off-by: so0k <vincent.drl@gmail.com>

stable/cluster-autoscaler/values.yaml

so0k · 2018-11-22T10:13:55Z

Who do I need to ping to have this merged? @unguiculus / @davidkarlsen - I can fix merge conflicts, but would like to know if there's any chance this gets merged after I fix, or I should just close and keep a local fork?

so0k · 2018-12-06T16:02:26Z

Chart versions shouldn't just be bumped without reading the changelog of the newly released versions they're supposed to support.

so0k · 2018-12-06T16:05:27Z

Deleting similar comments, had a github timeout telling me comment failed, but it seems it was posted multiple times

stale · 2019-01-05T20:40:59Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Signed-off-by: so0k <vincent.drl@gmail.com>

so0k · 2019-01-22T18:20:45Z

@Multiply - I've updated my branch but honestly I've forked the chart as it's almost impossible to get anything merged on this repo.

linki · 2019-01-22T18:31:19Z

/lgtm

k8s-ci-robot · 2019-01-22T18:31:24Z

@linki: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

linki · 2019-01-22T18:31:45Z

/assign @paulczar
/unassign @linki

so0k · 2019-02-13T05:27:17Z

any update @paulczar

so0k · 2019-02-13T05:27:53Z

should I rebase again or should we just close and I use a fork as it seems most ppl use forks from helm stable as they lag behind

stale · 2019-03-15T06:18:13Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

so0k · 2019-03-20T05:19:40Z

@paulczar let's close this, I'll maintain my own fork as many features lacking here and getting things merged is not reasonable

stealthybox · 2019-03-20T05:35:16Z

This isn't really an effective place to bring this up, but I find the OWNERS file based governance of helm/charts to be ineffective in comparison to how we merged changes here before.

Good patches are dying all the time now.

echoboomer · 2019-05-10T04:07:10Z

Please consider merging this one as a lot of people could benefit from it.

paulczar · 2019-05-10T16:06:53Z

/lgtm

k8s-ci-robot · 2019-05-10T16:07:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linki, paulczar, so0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [paulczar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* upstream/master: (4160 commits) [stable/mysql] support loadBalancerIP, configurationFilesPath (helm#13670) Allow setting an emptyDir sizeLimit for Prometheus (helm#12281) [stable/concourse] Add possibility to set strategy for rollingUpdates (web) (helm#13616) [stable/cluster-autoscaler] support dnsPolicy (helm#9029) [stable/rabbitmq-ha] allow setting different topology keys for anti affinity (helm#13635) [stable/airflow] Fix prometheusRule additionalLabels (helm#13683) [stable/postgresql] Set the right env. variable to enable debug (helm#13682) Use KUBERNETES_SERVICE_HOST environment variable (helm#13676) Enable new_k8s flag by default (helm#13618) [stable/prometheus-operator] Bump version dependency (helm#13625) [stable/odoo] Update Odoo dependencies (helm#13657) [stable/airflow] Add support for prometheus rules (helm#13662) [stable/signalfx-agent] Adding deprication notice (helm#13586) [stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC (helm#13495) stable/ambassador - Update to Ambassador 0.61.0 (helm#13661) [stable/redmine] Update Redmine dependencies (helm#13658) [stable/chart] Add deploymentStrategy on HackMD chart (helm#13645) [stable/grafana] Adds imagePullSecrets to test pod (helm#13574) [stable/k8s-dashboard] Clean up cluster-service label (helm#13545) [stable/postgresql] Fix 'mountPath' for password files. (helm#13653) ...

* [stable/cluster-autoscaler] Add dnsPolicy Signed-off-by: swo0k <vincentdesmet@swatmobile.io> * [stable/cluster-autoscaler] Bump to 0.9.1 Signed-off-by: swo0k <vincentdesmet@swatmobile.io> * [stable/cluster-autoscaler] Drop high verbosity from chart defaults Signed-off-by: so0k <vincent.drl@gmail.com> * [stable/cluster-autoscaler] Revert default verbosity config Signed-off-by: so0k <vincent.drl@gmail.com>

helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2018

k8s-ci-robot requested review from mgoodness and prydonius November 6, 2018 05:19

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2018

so0k force-pushed the cluster-autoscaler-dns-policy branch from 2445102 to 5d7b6bf Compare November 6, 2018 05:27

helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2018

so0k added 2 commits November 6, 2018 12:29

[stable/cluster-autoscaler] Add dnsPolicy

69946dd

Signed-off-by: swo0k <vincentdesmet@swatmobile.io>

[stable/cluster-autoscaler] Bump to 0.9.1

993032a

Signed-off-by: swo0k <vincentdesmet@swatmobile.io>

so0k force-pushed the cluster-autoscaler-dns-policy branch from 5d7b6bf to 993032a Compare November 6, 2018 05:29

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2018

k8s-ci-robot assigned linki Nov 6, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2018

helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2018

[stable/cluster-autoscaler] Drop high verbosity from chart defaults

7f761c7

Signed-off-by: so0k <vincent.drl@gmail.com>

so0k force-pushed the cluster-autoscaler-dns-policy branch from 2fc2a54 to 7f761c7 Compare November 6, 2018 10:10

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2018

so0k commented Nov 6, 2018

View reviewed changes

stable/cluster-autoscaler/values.yaml Outdated Show resolved Hide resolved

[stable/cluster-autoscaler] Revert default verbosity config

0384736

Signed-off-by: so0k <vincent.drl@gmail.com>

so0k force-pushed the cluster-autoscaler-dns-policy branch from e03be08 to 0384736 Compare January 22, 2019 18:17

helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2019

k8s-ci-robot assigned paulczar and unassigned linki Jan 22, 2019

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2019

so0k closed this Mar 20, 2019

so0k reopened this May 10, 2019

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2019

Merge branch 'upstream-master' into cluster-autoscaler-dns-policy

0d78625

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2019

k8s-ci-robot merged commit 56db264 into helm:master May 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/cluster-autoscaler] support dnsPolicy #9029

[stable/cluster-autoscaler] support dnsPolicy #9029

so0k commented Nov 6, 2018 •

edited

Loading

so0k commented Nov 6, 2018

davidkarlsen commented Nov 6, 2018

so0k commented Nov 22, 2018

so0k commented Dec 6, 2018

so0k commented Dec 6, 2018 •

edited

Loading

stale bot commented Jan 5, 2019

so0k commented Jan 22, 2019

linki commented Jan 22, 2019

k8s-ci-robot commented Jan 22, 2019

linki commented Jan 22, 2019 •

edited

Loading

so0k commented Feb 13, 2019

so0k commented Feb 13, 2019

stale bot commented Mar 15, 2019

so0k commented Mar 20, 2019 •

edited

Loading

stealthybox commented Mar 20, 2019

echoboomer commented May 10, 2019

paulczar commented May 10, 2019

k8s-ci-robot commented May 10, 2019

[stable/cluster-autoscaler] support dnsPolicy #9029

[stable/cluster-autoscaler] support dnsPolicy #9029

Conversation

so0k commented Nov 6, 2018 • edited Loading

Checklist

so0k commented Nov 6, 2018

davidkarlsen commented Nov 6, 2018

so0k commented Nov 22, 2018

so0k commented Dec 6, 2018

so0k commented Dec 6, 2018 • edited Loading

stale bot commented Jan 5, 2019

so0k commented Jan 22, 2019

linki commented Jan 22, 2019

k8s-ci-robot commented Jan 22, 2019

linki commented Jan 22, 2019 • edited Loading

so0k commented Feb 13, 2019

so0k commented Feb 13, 2019

stale bot commented Mar 15, 2019

so0k commented Mar 20, 2019 • edited Loading

stealthybox commented Mar 20, 2019

echoboomer commented May 10, 2019

paulczar commented May 10, 2019

k8s-ci-robot commented May 10, 2019

so0k commented Nov 6, 2018 •

edited

Loading

so0k commented Dec 6, 2018 •

edited

Loading

linki commented Jan 22, 2019 •

edited

Loading

so0k commented Mar 20, 2019 •

edited

Loading