Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC #13495

Merged
merged 2 commits into from
May 9, 2019
Merged

[stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC #13495

merged 2 commits into from
May 9, 2019

Conversation

marcostvz
Copy link
Contributor

Useful for imagePullSecrets

Signed-off-by: Marcos Estevez marcos.stvz@gmail.com

What this PR does / why we need it:

Currently it is not possible to disable RBAC and yet deploying the ServiceAccount. In my use case I need that to use imagePullSecrets

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@marcostvz
[stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC
efc654c 
Useful for imagePullSecrets

Signed-off-by: Marcos Estevez <marcos.stvz@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @marcostvz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marcostvz
Copy link
Contributor Author

/assign davidkarlsen

@davidkarlsen
Copy link
Member

/assign
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, marcostvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 10bed0a into helm:master May 9, 2019
stackedsax added a commit to stackedsax/charts that referenced this pull request May 12, 2019
@stackedsax
Merge remote-tracking branch 'upstream/master' into storm_chart
57d7eab 
* upstream/master: (4160 commits)
  [stable/mysql] support loadBalancerIP, configurationFilesPath (helm#13670)
  Allow setting an emptyDir sizeLimit for Prometheus (helm#12281)
  [stable/concourse] Add possibility to set strategy for rollingUpdates (web) (helm#13616)
  [stable/cluster-autoscaler] support dnsPolicy (helm#9029)
  [stable/rabbitmq-ha] allow setting different topology keys for anti affinity (helm#13635)
  [stable/airflow] Fix prometheusRule additionalLabels (helm#13683)
  [stable/postgresql] Set the right env. variable to enable debug (helm#13682)
  Use KUBERNETES_SERVICE_HOST environment variable (helm#13676)
  Enable new_k8s flag by default (helm#13618)
  [stable/prometheus-operator] Bump version dependency (helm#13625)
  [stable/odoo] Update Odoo dependencies (helm#13657)
  [stable/airflow] Add support for prometheus rules (helm#13662)
  [stable/signalfx-agent] Adding deprication notice (helm#13586)
  [stable/kube-state-metrics] Allows deploying ServiceAccount without RBAC (helm#13495)
  stable/ambassador - Update to Ambassador 0.61.0 (helm#13661)
  [stable/redmine] Update Redmine dependencies (helm#13658)
  [stable/chart] Add deploymentStrategy on HackMD chart (helm#13645)
  [stable/grafana] Adds imagePullSecrets to test pod (helm#13574)
  [stable/k8s-dashboard] Clean up cluster-service label (helm#13545)
  [stable/postgresql] Fix 'mountPath' for password files. (helm#13653)
  ...
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@marcostvz @goshlanguage
[stable/kube-state-metrics] Allows deploying ServiceAccount without R…
cdc7dba 
…BAC (helm#13495)

Useful for imagePullSecrets

Signed-off-by: Marcos Estevez <marcos.stvz@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@marcostvz @eyenx
[stable/kube-state-metrics] Allows deploying ServiceAccount without R…
22e3435 
…BAC (helm#13495)

Useful for imagePullSecrets

Signed-off-by: Marcos Estevez <marcos.stvz@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prydonius prydonius Awaiting requested review from prydonius

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcostvz @k8s-ci-robot @davidkarlsen @helm-bot