Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/atlantis] Atlantis aws #14189

Merged
merged 4 commits into from
May 28, 2019
Merged

[stable/atlantis] Atlantis aws #14189

merged 4 commits into from
May 28, 2019

Conversation

wvidana
Copy link
Collaborator

@wvidana wvidana commented May 28, 2019 •
edited
Loading

What this PR does / why we need it:

Adds the option to provide a variable awsSecretName to reference a Secret instead of having the values in the values.yml

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@wvidana
Adding secret name reference for AWS credentials
e2294ac 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Version bump - new feature
7a8f774 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2019
@wvidana wvidana changed the title Atlantis aws [stable/atlantis] Atlantis aws May 28, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wvidana. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wvidana
Copy link
Collaborator Author

wvidana commented May 28, 2019

/assign @anubhavmishra

@wvidana
Copy link
Collaborator Author

wvidana commented May 28, 2019

/assign @lkysow

lkysow
lkysow suggested changes May 28, 2019
View reviewed changes
stable/atlantis/README.md Outdated Show resolved Hide resolved
@wvidana
Describe contents of AWS Secret for awsSecretName
fafe933 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
lkysow
lkysow suggested changes May 28, 2019
View reviewed changes
stable/atlantis/values.yaml Outdated Show resolved Hide resolved
@wvidana @lkysow
Update stable/atlantis/values.yaml
80adf75 
Co-Authored-By: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@lkysow
Copy link
Contributor

lkysow commented May 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkysow, wvidana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit d51ca6e into helm:master May 28, 2019
@wvidana wvidana deleted the atlantis-aws branch May 29, 2019 15:57
rvdh pushed a commit to rvdh/charts that referenced this pull request Jun 3, 2019
@wvidana @lkysow @rvdh
[stable/atlantis] Atlantis aws (helm#14189)
79a879d 
* Adding secret name reference for AWS credentials

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Version bump - new feature

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Describe contents of AWS Secret for awsSecretName

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update stable/atlantis/values.yaml

Co-Authored-By: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
davidkarlsen pushed a commit to davidkarlsen/charts that referenced this pull request Jun 5, 2019
@wvidana @lkysow @davidkarlsen
[stable/atlantis] Atlantis aws (helm#14189)
cd10592 
* Adding secret name reference for AWS credentials

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Version bump - new feature

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Describe contents of AWS Secret for awsSecretName

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Update stable/atlantis/values.yaml

Co-Authored-By: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
0d107ff 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665
@wvidana wvidana mentioned this pull request Sep 5, 2019
Merged
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
46aae01 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 7, 2019
@wvidana @k8s-ci-robot
[stable/cerebro] Adding wvidana as collaborator (#16909)
6fb92f2 
* Adding wvidana as collaborator

Volunteering from issue #13867

Past contributions to cerebro chart:
  - #14506

Past contributions to other helm charts:
  - #14196
  - #14189
  - #13667
  - #13666
  - #13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
22148f5 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
245f178 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@wvidana @dargolith
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
51e7345 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lkysow lkysow lkysow requested changes

@callmeradical callmeradical Awaiting requested review from callmeradical

@sstarcher sstarcher Awaiting requested review from sstarcher

Assignees

@lkysow lkysow

@anubhavmishra anubhavmishra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: allow user provide a Secret reference for AWS credentials
5 participants
@wvidana @k8s-ci-robot @lkysow @anubhavmishra @helm-bot