Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/atlantis] Make secret-webhook optional #13667

Merged
merged 5 commits into from
May 17, 2019
Merged

[stable/atlantis] Make secret-webhook optional #13667

merged 5 commits into from
May 17, 2019

Conversation

wvidana
Copy link
Collaborator

@wvidana wvidana commented May 9, 2019 •
edited
Loading

What this PR does / why we need it:

People might want to manage secrets on their own. This PR makes the secret-webhook from the templates optional if no git credentials are given.

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 9, 2019
@k8s-ci-robot k8s-ci-robot requested a review from jkodroff May 9, 2019 22:11
@k8s-ci-robot
Copy link
Contributor

Hi @wvidana. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2019
@wvidana wvidana mentioned this pull request May 9, 2019
Closed
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 10, 2019

/assign @lkysow

@wvidana
Copy link
Collaborator Author

wvidana commented May 16, 2019

@lkysow can you please review this PR? Or should I assign it to someone else?

@lkysow
Copy link
Contributor

lkysow commented May 16, 2019 •
edited
Loading

@wvidana sorry, this fell off my backlog, I'll take a look

lkysow
lkysow suggested changes May 16, 2019
View reviewed changes
stable/atlantis/Chart.yaml Show resolved Hide resolved
stable/atlantis/README.md Outdated Show resolved Hide resolved
stable/atlantis/templates/_helpers.tpl Outdated Show resolved Hide resolved
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 16, 2019
@wvidana
Make the template secret-webhook optional
859ab86 
People might want to manage secrets on their own

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Bump chart version
87c0148 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Using a variable to define the reference to the secret
e067a08 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
Renaming secretWebhookName to vcsSecretsName
1a8b12e 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana
New feature version
714619b 
Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 16, 2019
@wvidana
Copy link
Collaborator Author

wvidana commented May 16, 2019

Thanks for the review @lkysow ! Changes are ready again for revision.

@lkysow
Copy link
Contributor

lkysow commented May 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkysow, wvidana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ec10c8 into helm:master May 17, 2019
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@wvidana
[stable/atlantis] Make secret-webhook optional (helm#13667)
4e66d75 
* Make the template secret-webhook optional

People might want to manage secrets on their own

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Bump chart version

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Using a variable to define the reference to the secret

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Renaming secretWebhookName to vcsSecretsName

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* New feature version

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@wvidana @eyenx
[stable/atlantis] Make secret-webhook optional (helm#13667)
67a9379 
* Make the template secret-webhook optional

People might want to manage secrets on their own

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Bump chart version

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Using a variable to define the reference to the secret

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* Renaming secretWebhookName to vcsSecretsName

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>

* New feature version

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
@wvidana wvidana deleted the atlantis branch May 29, 2019 15:57
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
0d107ff 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665
@wvidana wvidana mentioned this pull request Sep 5, 2019
Merged
wvidana added a commit to wvidana/charts that referenced this pull request Sep 5, 2019
@wvidana
Adding wvidana as collaborator
46aae01 
Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>
k8s-ci-robot pushed a commit that referenced this pull request Nov 7, 2019
@wvidana @k8s-ci-robot
[stable/cerebro] Adding wvidana as collaborator (#16909)
6fb92f2 
* Adding wvidana as collaborator

Volunteering from issue #13867

Past contributions to cerebro chart:
  - #14506

Past contributions to other helm charts:
  - #14196
  - #14189
  - #13667
  - #13666
  - #13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
22148f5 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@wvidana
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
245f178 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@wvidana @dargolith
[stable/cerebro] Adding wvidana as collaborator (helm#16909)
51e7345 
* Adding wvidana as collaborator

Volunteering from issue helm#13867

Past contributions to cerebro chart:
  - helm#14506

Past contributions to other helm charts:
  - helm#14196
  - helm#14189
  - helm#13667
  - helm#13666
  - helm#13665

Signed-off-by: Wilfrido Vidana <wilfrido.vidana@omf.com>

* Adding the OWNERS file to .helmignore

Signed-off-by: Wilfrido Vidana <wvidanas@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lkysow lkysow lkysow requested changes

@callmeradical callmeradical Awaiting requested review from callmeradical

@jkodroff jkodroff Awaiting requested review from jkodroff

Assignees

@lkysow lkysow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/atlantis] Manage webhook secrets separately
4 participants
@wvidana @k8s-ci-robot @lkysow @helm-bot