Fix regression by pr #13000 #13925
Fix regression by pr #13000 #13925
Conversation
This reverts the incorrect patch merged as part of pr #13000 as well as adds warnings so that hopefully this never happens again.` Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
helm-bot
added
size/S
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @kfox1111. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kfox1111: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@kfox1111: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Did you accept the invite? |
|
LGTM |
|
@kfox1111 you should be able to do ok-to-test |
Just did. thanks. /ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfox1111, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts the incorrect patch merged as part of pr helm#13000 as well as adds warnings so that hopefully this never happens again.` Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
This reverts the incorrect patch merged as part of pr helm#13000 as well as adds warnings so that hopefully this never happens again.` Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
This reverts the incorrect patch merged as part of pr #13000 as
well as adds warnings so that hopefully this never happens again.