Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Change indent from 8 to 4 #13000

Merged
merged 2 commits into from
May 16, 2019
Merged

Change indent from 8 to 4 #13000

merged 2 commits into from
May 16, 2019

Conversation

flands
Copy link
Contributor

@flands flands commented Apr 12, 2019 •
edited
Loading

What this PR does / why we need it:

Some fluent-bit configurations do not work today

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped

Signed-off-by: Steve Flanders steve@sflanders.net

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @flands. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2019
@flands
Copy link
Contributor Author

flands commented Apr 12, 2019

PTAL @kfox1111 @edsiper

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 15, 2019
@flands
Change indent from 8 to 4
6d14097 
Addresses #12106

Signed-off-by: Steve Flanders <steve@omnition.io>
@sirrapa
Copy link

sirrapa commented Apr 24, 2019

@kfox1111 @edsiper Can you Review the PR please? We are waiting for this PR.

@maorfr
Copy link
Member

maorfr commented May 16, 2019

/assign
/ok-to-test
/lgtm

thanks!

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flands, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit a5a1016 into helm:master May 16, 2019
@kfox1111
Copy link
Collaborator

Good grief, not again! Stop merging these things!

@maorfr
Copy link
Member

maorfr commented May 16, 2019

@kfox1111 how come?

@kfox1111
Copy link
Collaborator

This was forced through once before. breaking the api. then we undid it. then its happening again. Another breaking change. :(

The result last time was we came up with rawConfig for those that wanted to add sections. extraEntries is for adding entries to the existing sections. :(

That this keeps happening seems like we really need some kind of howto use thing.

@maorfr
Copy link
Member

maorfr commented May 16, 2019

i have added you as a collaborator, so from now on you and @edsiper can own this with less other maintainers getting in the way! :)

@kfox1111
Copy link
Collaborator

Thank you. :)

@kfox1111 kfox1111 mentioned this pull request May 16, 2019
Merged
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@flands @goshlanguage
Change indent from 8 to 4 (helm#13000)
b712a7b 
Addresses helm#12106

Signed-off-by: Steve Flanders <steve@omnition.io>
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@flands
Change indent from 8 to 4 (helm#13000)
f90cbcb 
Addresses helm#12106

Signed-off-by: Steve Flanders <steve@omnition.io>
amine7536 pushed a commit to amine7536/charts that referenced this pull request May 21, 2019
@kfox1111
Fix regression by pr helm#13000 (helm#13925)
babaae6 
This reverts the incorrect patch merged as part of pr helm#13000 as
well as adds warnings so that hopefully this never happens again.`

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@flands @eyenx
Change indent from 8 to 4 (helm#13000)
23ca6c1 
Addresses helm#12106

Signed-off-by: Steve Flanders <steve@omnition.io>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@kfox1111 @eyenx
Fix regression by pr helm#13000 (helm#13925)
7d5b8db 
This reverts the incorrect patch merged as part of pr helm#13000 as
well as adds warnings so that hopefully this never happens again.`

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsiper edsiper Awaiting requested review from edsiper

Assignees

@maorfr maorfr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/fluent-bit] indent 8 should be indent 4?
6 participants
@flands @k8s-ci-robot @sirrapa @maorfr @kfox1111 @helm-bot