-
Notifications
You must be signed in to change notification settings - Fork 16.8k
stable/logdna-agent The value autoupdate for logdna-agent should be processed as a string #13496
stable/logdna-agent The value autoupdate for logdna-agent should be processed as a string #13496
Conversation
Signed-off-by: Harry Lascelles <harry@harrylascelles.com>
Hi @hlascelles. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This is still a valid PR. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hlascelles, paulczar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elm#13496) Signed-off-by: Harry Lascelles <harry@harrylascelles.com> Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
…elm#13496) Signed-off-by: Harry Lascelles <harry@harrylascelles.com>
What this PR does / why we need it:
The logdna-agent should be processing the autoupdate value as a string (as all ENV should be). For example, if no value is supplied, the
values.yaml
default is used, which is a number (0
), which causes a comparison type failure when this comparison takes place against a string.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
Signed-off-by: Harry Lascelles harry@harrylascelles.com