-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smusali If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @smusali. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a964c5e
to
b6fd9d4
Compare
* v1.1.0 * Update README.md Signed-off-by: Samir Musali <samir.musali@logdna.com>
Signed-off-by: Samir Musali <samir.musali@logdna.com>
Can you quickly approve this Thanks in advance! |
…, Chart, Values, and DaemonSet Signed-off-by: Samir Musali <samir.musali@logdna.com>
Signed-off-by: Samir Musali <samir.musali@logdna.com>
are you sure that it fixes #13869 ? |
@maorfr, doesn't it? This PR contains |
right, but it will close the issue, which is not what we want. |
@maorfr, I see - I'll remove that part from description |
i think you will have to close and reopen |
Can you quickly approve this Pull Request? It has passed all checks! This is just addition! And it is waiting for Thanks in advance! |
can we rebase and resolve conflicts? i'll approve it. |
@smusali any chance of getting this rebased and approved? I was about to submit a similar PR for the apihost and loghost variables but didn't want to duplicate this one. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
v1.1.0
Update README.md
What this PR does / why we need it:
autoupdate
Type MismatchSecrets
TemplateLogDNA API Hostname
LogDNA Ingestion Hostname
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)