Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

add support for pod disruption budget #13220

Merged
merged 3 commits into from
Apr 24, 2019
Merged

add support for pod disruption budget #13220

merged 3 commits into from
Apr 24, 2019

Conversation

jaypatrickhoward
Copy link
Contributor

What this PR does / why we need it:

Adds support for Pod Disruption Budget.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@jaypatrickhoward
add support for pod disruption budget
78016b1 
Signed-off-by: Jay Howard <jay.howard@rmn.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jaypatrickhoward. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

olemarkus
olemarkus reviewed Apr 24, 2019
View reviewed changes
Copy link
Contributor

@olemarkus olemarkus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I wonder if not the way that e.g prometheus-operator implements this is better though. Where you have to specify something like this in the values file:

    enabled: false
    minAvailable: 1
    maxUnavailable: ""

Less flexible, but more explicit and user friendly.

stable/metrics-server/Chart.yaml Outdated
@@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.3.2
description: Metrics Server is a cluster-wide aggregator of resource usage data.
name: metrics-server
version: 2.6.0
version: 2.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump minor version here?

stable/metrics-server/values.yaml

# The values to set in the PodDisruptionBudget spec (minAvailable/maxUnavailable)
# If not set then a PodDisruptionBudget will not be created
podDisruptionBudget:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a (commented out) example of what is users should add here? Right now, one has to look at the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I have another nearly-identical PR pending for the kubernetes-dashboard chart. Do you advise preemptively making the same changes there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify: all the changes, not just the additional documentation in values.yaml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advice that yes. The kubernetes-dashboard maintainer may have other preferences though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and made the changes over there as well. No response yet, but I'm happy to do it whichever way they prefer.

@olemarkus
Copy link
Contributor

/assign

@jaypatrickhoward
explicitly support current pod disruption budget options
b3a0424 
Signed-off-by: Jay Howard <jay.howard@rmn.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
@jaypatrickhoward
lint: add newline at end of file
ab3e56d 
Signed-off-by: Jay Howard <jay.howard@rmn.com>
@jaypatrickhoward jaypatrickhoward mentioned this pull request Apr 24, 2019
Merged
3 tasks
@olemarkus
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypatrickhoward, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4c8975d into helm:master Apr 24, 2019
@jaypatrickhoward jaypatrickhoward deleted the PodDisruptionBudget_metrics-server branch April 24, 2019 21:15
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
@devnulled
add support for pod disruption budget (helm#13220)
7b79a38 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* explicitly support current pod disruption budget options

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* lint: add newline at end of file

Signed-off-by: Jay Howard <jay.howard@rmn.com>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
add support for pod disruption budget (helm#13220)
752d3d4 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* explicitly support current pod disruption budget options

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* lint: add newline at end of file

Signed-off-by: Jay Howard <jay.howard@rmn.com>
dpkirchner pushed a commit to dpkirchner/charts that referenced this pull request May 9, 2019
@dpkirchner
add support for pod disruption budget (helm#13220)
e88055b 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* explicitly support current pod disruption budget options

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* lint: add newline at end of file

Signed-off-by: Jay Howard <jay.howard@rmn.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@goshlanguage
add support for pod disruption budget (helm#13220)
164036a 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* explicitly support current pod disruption budget options

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* lint: add newline at end of file

Signed-off-by: Jay Howard <jay.howard@rmn.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@eyenx
add support for pod disruption budget (helm#13220)
4ce84c4 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* explicitly support current pod disruption budget options

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* lint: add newline at end of file

Signed-off-by: Jay Howard <jay.howard@rmn.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olemarkus olemarkus olemarkus left review comments

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaypatrickhoward @k8s-ci-robot @olemarkus @helm-bot