Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

add support for pod disruption budget #13215

Merged
merged 4 commits into from
Apr 30, 2019
Merged

add support for pod disruption budget #13215

merged 4 commits into from
Apr 30, 2019

Conversation

jaypatrickhoward
Copy link
Contributor

What this PR does / why we need it:

Adds support for Pod Disruption Budget.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@jaypatrickhoward
add support for pod disruption budget
7154f88 
Signed-off-by: Jay Howard <jay.howard@rmn.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 23, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jaypatrickhoward. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaypatrickhoward
Copy link
Contributor Author

Will make the PodDisruptionBudget paramters explicit, per the change to this PR:

#13220

@jaypatrickhoward
support pod disruption budget parameters explicitly; bump minor version
c3479f2 
Signed-off-by: Jay Howard <jay.howard@rmn.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
jaypatrickhoward and others added 2 commits April 30, 2019 10:14
@jaypatrickhoward
remove default values for minAvailable and maxUnavailable since they'…
d735176 
…re mutually exclusive and neither is required

Signed-off-by: Jay Howard <jay.howard@rmn.com>
Merge branch 'master' into PodDisruptionBudget
9dd5199
@jaypatrickhoward
Copy link
Contributor Author

Let me know if there's anything you'd like done differently, @kfox1111 and @desaintmartin .

@davidkarlsen
Copy link
Member

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2019
@kfox1111
Copy link
Collaborator

/lgtm

Thanks for contributing. :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypatrickhoward, kfox1111

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4120bbf into helm:master Apr 30, 2019
dpkirchner pushed a commit to dpkirchner/charts that referenced this pull request May 9, 2019
@dpkirchner
add support for pod disruption budget (helm#13215)
72b8ebd 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* support pod disruption budget parameters explicitly; bump minor version

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* remove default values for minAvailable and maxUnavailable since they're mutually exclusive and neither is required

Signed-off-by: Jay Howard <jay.howard@rmn.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
@goshlanguage
add support for pod disruption budget (helm#13215)
c81a867 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* support pod disruption budget parameters explicitly; bump minor version

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* remove default values for minAvailable and maxUnavailable since they're mutually exclusive and neither is required

Signed-off-by: Jay Howard <jay.howard@rmn.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
@eyenx
add support for pod disruption budget (helm#13215)
68323d8 
* add support for pod disruption budget

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* support pod disruption budget parameters explicitly; bump minor version

Signed-off-by: Jay Howard <jay.howard@rmn.com>

* remove default values for minAvailable and maxUnavailable since they're mutually exclusive and neither is required

Signed-off-by: Jay Howard <jay.howard@rmn.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desaintmartin desaintmartin Awaiting requested review from desaintmartin

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaypatrickhoward @k8s-ci-robot @davidkarlsen @kfox1111 @helm-bot