Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] - Move tracer tags to process #7027

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[3.x] - Move tracer tags to process #7027

merged 2 commits into from
Jun 21, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #7024 fir Helidon 3.

@dalexandrov dalexandrov added enhancement New feature or request tracing 3.x Issues for 3.x version branch labels Jun 20, 2023
@dalexandrov dalexandrov self-assigned this Jun 20, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 20, 2023
@dalexandrov
Rollback unnecessary formatting
f694c8b 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Copy link
Contributor Author

@tomas-langer this PR addresses the request to move tracer tags to Process tap in Jaeger. Thus tags become parts of the Resource attributes. This sounds reasonable. Would you please confirm.

tomas-langer
tomas-langer requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks ok, but I am missing a way to validate this.
This deserves a test (that fails on original code, and works with the changes)

@dalexandrov
Copy link
Contributor Author

As Span and Tracer provide only setter interfaces, this will require additional integration tests.

tomas-langer
tomas-langer approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference the follow up to create a test here. Thanks!

@dalexandrov
Copy link
Contributor Author

Follow up issue created #7035

@dalexandrov dalexandrov merged commit 2dbbd84 into helidon-io:helidon-3.x Jun 21, 2023
@dalexandrov dalexandrov deleted the 7024_3.x_move_tracer_tags_to_process branch June 21, 2023 11:58
@tjquinno tjquinno mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@dalexandrov dalexandrov

Labels
3.x Issues for 3.x version branch enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement. tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process tags show as span tags in Jaeger viewer with helidon-tracing-jaeger
2 participants
@dalexandrov @tomas-langer